From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 40407@debbugs.gnu.org, "Mattias Engdegård" <mattiase@acm.org>
Subject: bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE
Date: Mon, 06 Apr 2020 19:10:48 +0900 [thread overview]
Message-ID: <87blo46i1j.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <835zegwn9y.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 03 Apr 2020 19:24:09 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> - if (BUFFERP (dst_object))
>> + if (EQ (dst_object, Qt))
>> + {
>> + /* Fast path for ASCII-only input and an ASCII-compatible coding:
>> + act as identity. */
>> + Lisp_Object attrs = CODING_ID_ATTRS (coding.id);
>> + if (! NILP (CODING_ATTR_ASCII_COMPAT (attrs))
>> + && (STRING_MULTIBYTE (string)
>> + ? (chars == bytes) : string_ascii_p (string)))
>> + return string;
While using the latest master branch, I noticed this became the cause of
decoding error.
The simple reproducible test is,
(decode-coding-string "&abc" 'utf-7-imap)
=> "&abc"
like the above result, decoding utf-7-imap didn't work.
Because (coding-system-get 'utf-7-imap :ascii-compatible-p) => t.
I'm not sure, 'utf-7* should be fixed as non ascii-compatible, or
string_ascii_p() should check more strictly.
[BTW,
(define-coding-system 'utf-7-imap
"UTF-7 encoding of Unicode, IMAP version (RFC 2060)"
:coding-type 'utf-8
:mnemonic ?u
:charset-list '(unicode)
:ascii-compatible-p nil ;; <=== added this line
:pre-write-conversion 'utf-7-imap-pre-write-conversion
:post-read-conversion 'utf-7-imap-post-read-conversion)
doesn't work. Because define-coding-system-internal overwrites
ascii-compatible-p.]
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2020-04-06 10:10 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 14:18 bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE Mattias Engdegård
2020-04-03 16:24 ` Eli Zaretskii
2020-04-03 22:32 ` Mattias Engdegård
2020-04-04 9:26 ` Eli Zaretskii
2020-04-04 16:41 ` Mattias Engdegård
2020-04-04 17:22 ` Eli Zaretskii
2020-04-04 17:37 ` Eli Zaretskii
2020-04-04 18:06 ` Mattias Engdegård
2020-04-05 2:37 ` Eli Zaretskii
2020-04-05 3:42 ` Eli Zaretskii
2020-04-05 10:14 ` Mattias Engdegård
2020-04-05 13:28 ` Eli Zaretskii
2020-04-05 13:40 ` Mattias Engdegård
2020-04-04 10:26 ` Eli Zaretskii
2020-04-04 16:55 ` Mattias Engdegård
2020-04-04 17:04 ` Eli Zaretskii
2020-04-04 18:01 ` Mattias Engdegård
2020-04-04 18:25 ` Eli Zaretskii
2020-04-05 10:48 ` Mattias Engdegård
2020-04-05 13:39 ` Eli Zaretskii
2020-04-05 15:03 ` Mattias Engdegård
2020-04-05 15:35 ` Mattias Engdegård
2020-04-05 15:56 ` Eli Zaretskii
2020-04-06 18:13 ` Mattias Engdegård
2020-04-05 16:00 ` Eli Zaretskii
2020-04-06 10:10 ` OGAWA Hirofumi [this message]
2020-04-06 14:21 ` Eli Zaretskii
2020-04-06 15:56 ` Mattias Engdegård
2020-04-06 16:33 ` Eli Zaretskii
2020-04-06 16:55 ` Mattias Engdegård
2020-04-06 17:18 ` Eli Zaretskii
2020-04-06 17:49 ` Mattias Engdegård
2020-04-06 18:20 ` Eli Zaretskii
2020-04-06 18:34 ` OGAWA Hirofumi
2020-04-06 21:57 ` Mattias Engdegård
2020-04-09 11:03 ` Mattias Engdegård
2020-04-09 14:09 ` Kazuhiro Ito
2020-04-09 14:22 ` Mattias Engdegård
2020-04-11 15:09 ` Mattias Engdegård
2020-04-16 13:11 ` handa
2020-04-16 13:44 ` Eli Zaretskii
2020-04-16 13:59 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blo46i1j.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=40407@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.