From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: eww and bookmarks Date: Mon, 08 Jun 2020 17:58:21 +0100 Message-ID: <87bllt1olu.fsf@tcd.ie> References: <87k1163jz5.fsf@gmail.com> <87tv0a5k5b.fsf@web.de> <87mu5ec3pf.fsf@web.de> <87mu5e3ncg.fsf@tcd.ie> <87tuzlwrdv.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="5357"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 08 19:05:00 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiLCl-0001Eo-9R for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Jun 2020 19:04:59 +0200 Original-Received: from localhost ([::1]:35354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiLCk-0006A6-Aa for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Jun 2020 13:04:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiL6P-0006vj-Tn for emacs-devel@gnu.org; Mon, 08 Jun 2020 12:58:25 -0400 Original-Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:53075) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiL6P-0001dF-4z for emacs-devel@gnu.org; Mon, 08 Jun 2020 12:58:25 -0400 Original-Received: by mail-wm1-x334.google.com with SMTP id r9so216889wmh.2 for ; Mon, 08 Jun 2020 09:58:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=JN/m/WQVuhTi+uVbVHtJ2iIP4d4i0XjUxEfp2ElmhuI=; b=AhpnFMsjgqlVvzAP0kSey7SBA+f/mEQAuZsDlSzBKFsbjErrPppnYKf3XUqrHSDOs4 HVc8pNCL3IW2q4atxXpDVRL0+7gQdLIwcGzOxtEcDgTIXEcDboSy7y2xcp6jIGYt4tId TZHrs9+xfz0hQ714FOLeigAsKVvffjKfzhzjn0nbgu9XdinjjqYpuesaREe8thZwoVrH n3VxlJeJH4KJSXoio/CLO4Hb8P9PYD9tvdkyXVtLlvtKKoVJpKjQEadmKbLGmZfWmE5l 1URAvqJfQDRE/BwmRKpvQn8W4X6cILa94vAnV8rkFketw2GYhYWRpoG195tsRt15doKq A6Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=JN/m/WQVuhTi+uVbVHtJ2iIP4d4i0XjUxEfp2ElmhuI=; b=V6GIf8fmLunourX3wJaOW9+u3NNYqfc1lu1re8Z1KKztz+VdKrTIASFlnqTOVD6vM0 4BzwiMOEAiQ9nlNgBto73P1PU87oPWpwn/BRM2ycyu49pkmfwx/Es5il9RKB1sOrFrUC hdv2Vyz2ok+AE0SZFisQ4N57jI8ugz5uAwxJecHJbl1kdfaMK4Fiy9IxuFNFQRQ6xiW9 RCasgJ+65vy0B/I/rFFV2SiL9/qzS81EhOtzSZNVDKOAGLyE+f4Fdpn6AlplwXAUyiV+ UL7Z2qpussq/ZRHSlYrUKbAJUowjCM25T2UsbnNlDDet/ZDU2K3PK1m7Jt5L3PfpWRdL O/hQ== X-Gm-Message-State: AOAM533pCTIXLMOfklVPM75fyNHpCi8ZBuEe0znoW5tQf3Gkfi7+qoEu LiaHe0rXXMKHdeMpVFY3jIx78g== X-Google-Smtp-Source: ABdhPJys9k+syD/GVHiiLH6n5FUL9lhG3bbCH30C6E0YdhGWkXbFkVffTRhdm5992n6vVtc5bDs/4g== X-Received: by 2002:a1c:9dc7:: with SMTP id g190mr259906wme.129.1591635502537; Mon, 08 Jun 2020 09:58:22 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id s7sm306551wrr.60.2020.06.08.09.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:58:22 -0700 (PDT) In-Reply-To: <87tuzlwrdv.fsf@web.de> (Michael Heerdegen's message of "Mon, 08 Jun 2020 16:42:36 +0200") Received-SPF: none client-ip=2a00:1450:4864:20::334; envelope-from=contovob@tcd.ie; helo=mail-wm1-x334.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252048 Archived-At: Michael Heerdegen writes: > "Basil L. Contovounesios" writes: > >> > +(defcustom bookmark-eww-browse-url-function #'eww-browse-url >> > + "Doc..." >> > + :type '(choice >> > + (function-item eww-browse-url :doc "Use eww") >> > + (const :tag "Use value of `browse-url-browser-function'" nil) >> > + function)) >> >> Isn't it strange having a boookmark-... variable defined in eww.el? > > Yes. OTOH I wanted to avoid the risk of confusion with eww bookmarks > and not call it "eww-bookmark-...". Suggestions? Is the proposed bookmark.el support not meant to supersede EWW's current bookmark system? Anyway, what about eww-browse-bookmark-function? >> > +(defun eww--bookmark-title (title-string) >> > + (replace-regexp-in-string >> > + "\\` +\\| +\\'" "" >> > + (replace-regexp-in-string "[\n\t\r]" " " title-string))) >> >> Is the outer replace-regexp-in-string doing the same as string-trim? > > Is it? I didn't touch that code, I only moved it for factoring. That's what it looks like to me, but you can obviously leave it alone for now. >> > +(defun eww-bookmark-make-record () >> > + "Create an emacs bookmark record >> ^^^^^ >> Capitalize > > Done. > >> > for an eww buffer. >> > ^^^ >> > Upcase > > Is it ok to leave it downcased? That's what Lars asked for, so yes. -- Basil