From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#40919: 27.0.91; next-error-select-buffer does not always behave as documented Date: Fri, 12 Jun 2020 01:43:29 +0300 Organization: LINKOV.NET Message-ID: <87bllp1b1e.fsf@mail.linkov.net> References: <53913bd9-2bdc-0f70-f7b4-744283e0512f@ieee.org> <87d07rmb6j.fsf@mail.linkov.net> <87zhau5bfw.fsf@mail.linkov.net> <66f63b16-307a-919c-1d25-60ff63f92ae6@ieee.org> <87bln8u3xq.fsf@mail.linkov.net> <851cd382-4b2e-447a-2212-919c8a4ce908@ieee.org> <87d07lykkd.fsf@mail.linkov.net> <83bln5rbah.fsf@gnu.org> <87zhaozlvo.fsf@mail.linkov.net> <87v9kr8t1s.fsf@mail.linkov.net> <87zh9yuw5o.fsf@mail.linkov.net> <251b7e0d-ef94-e438-4023-a6513b611725@yandex.ru> <87lfl6tojw.fsf@mail.linkov.net> <87a71amsho.fsf@mail.linkov.net> <0138e3ed-2bf7-1d07-b5d1-7a4f3786e865@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="22300"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 40919@debbugs.gnu.org, tspiteri@ieee.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 12 01:39:28 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjWn9-0005hG-MQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jun 2020 01:39:27 +0200 Original-Received: from localhost ([::1]:48704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjWn8-0003b2-ON for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jun 2020 19:39:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjWml-0002zL-GE for bug-gnu-emacs@gnu.org; Thu, 11 Jun 2020 19:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55073) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjWml-0001F0-7V for bug-gnu-emacs@gnu.org; Thu, 11 Jun 2020 19:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jjWml-0005p2-4f for bug-gnu-emacs@gnu.org; Thu, 11 Jun 2020 19:39:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jun 2020 23:39:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40919 X-GNU-PR-Package: emacs Original-Received: via spool by 40919-submit@debbugs.gnu.org id=B40919.159191872922314 (code B ref 40919); Thu, 11 Jun 2020 23:39:03 +0000 Original-Received: (at 40919) by debbugs.gnu.org; 11 Jun 2020 23:38:49 +0000 Original-Received: from localhost ([127.0.0.1]:38376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjWmX-0005nj-9u for submit@debbugs.gnu.org; Thu, 11 Jun 2020 19:38:49 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:45363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjWmQ-0005n6-Qb for 40919@debbugs.gnu.org; Thu, 11 Jun 2020 19:38:43 -0400 X-Originating-IP: 91.129.108.6 Original-Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 10F5F240002; Thu, 11 Jun 2020 23:38:34 +0000 (UTC) In-Reply-To: <0138e3ed-2bf7-1d07-b5d1-7a4f3786e865@yandex.ru> (Dmitry Gutov's message of "Thu, 11 Jun 2020 02:32:44 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181878 Archived-At: > what kind of functions do they want to put on there? Both next-error-buffer-on-selected-frame and next-error-no-navigation-try-current. > And/or would they be content to advice-add on > next-error-find-buffer-function instead? Is it possible to add advice-add by using customization? >> -(defcustom next-error-find-buffer-function #'ignore >> +(defcustom next-error-find-buffer-function '(ignore) > > ^s, maybe? Ok, when using as a hook it could be '-functions', but in case of using advice-add it should be still '-function'. >> + (or (and (functionp next-error-find-buffer-function) >> + (funcall next-error-find-buffer-function avoid-current >> + extra-test-inclusive extra-test-exclusive)) >> + (and (listp next-error-find-buffer-function) >> + (run-hook-with-args-until-success >> + 'next-error-find-buffer-function avoid-current >> + extra-test-inclusive extra-test-exclusive))) > > Looks like run_hook_with_args can deal with the case where the value of the > hook is a single function. Ok, if it's impossible to use advice-add then lets simplify the hook case. >> ;; 2. If next-error-last-buffer is an acceptable buffer, use that. >> (if (and next-error-last-buffer >> (next-error-buffer-p next-error-last-buffer avoid-current > > Should we take the rest of the cases in next-error-find-buffer and move > them to the default value of the above hook? I don't think so, I don't believe someone might want to customize the rest of the cases.