From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#42184: 27.0.91; org-fontify-whole-heading-line does not work in emacs 27 Date: Sun, 05 Jul 2020 10:57:34 +0200 Message-ID: <87blkufif5.fsf@gmail.com> References: <5effe96e.1c69fb81.3a20a.f99f@mx.google.com> <87mu4f2ofd.fsf@gmail.com> <83wo3jtd0t.fsf@gnu.org> <87h7un2mq9.fsf@gmail.com> <87y2nzvz13.fsf@gmail.com> <83o8ouu200.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35454"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: egh@e6h.org, 42184@debbugs.gnu.org, mail@nicolasgoaziou.fr, bzg@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 05 10:58:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1js0TT-00096N-07 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jul 2020 10:58:11 +0200 Original-Received: from localhost ([::1]:59506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1js0TR-0001a6-Rk for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jul 2020 04:58:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1js0TK-0001Zt-OS for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 04:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48471) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1js0TK-0001GF-Fa for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 04:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1js0TK-0000YT-Dj for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 04:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jul 2020 08:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42184 X-GNU-PR-Package: emacs Original-Received: via spool by 42184-submit@debbugs.gnu.org id=B42184.15939394672112 (code B ref 42184); Sun, 05 Jul 2020 08:58:02 +0000 Original-Received: (at 42184) by debbugs.gnu.org; 5 Jul 2020 08:57:47 +0000 Original-Received: from localhost ([127.0.0.1]:60017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1js0T4-0000Y0-Vc for submit@debbugs.gnu.org; Sun, 05 Jul 2020 04:57:47 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:40893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1js0T1-0000Xj-Eb for 42184@debbugs.gnu.org; Sun, 05 Jul 2020 04:57:45 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id f139so38475665wmf.5 for <42184@debbugs.gnu.org>; Sun, 05 Jul 2020 01:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=JzBfLhA6GgMEF4jKKvy2Ut7PSVRYe6OEoSN2UlOkJhg=; b=mBLiTxzM5KTt2024GrnZyahWxW3QE6PC/YbQIdrn2STH7y0Gr/HiKJFpRpbpNKvWwJ 4F6Kc/1WR+R32KECwijIUvwyCXS0qp8wNU36hIzG4H5oIJ5Pq2wGfqwYAwoEJhOnTfO5 S5x5+n0Vg8VQhQvGnkXggYKi19uYokzQTMt3go5FlSUbsJ7n6s9/8W7v3a/wO27U+tBB xbKcdQgXTK7a+d0Jetc8+CeiVCNK2ZLWLxpHqB90hQG8XbI5I8sNnUjWcnoHFtGOeumi HXs7D1+R6cGM5eh0CFkd7TgYDxjMSc29f2UWHMHv62pwy6tA5vDjgfq5fMDkF3zMi/On dw1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=JzBfLhA6GgMEF4jKKvy2Ut7PSVRYe6OEoSN2UlOkJhg=; b=Ak6k2WYGhTtC1IcxDfl26vmec2/da64Y3iH/a98hxq4qRMMnQYbH5UUEmXDRjgi9IH mtTp6OuPcAy3tCCkxNsdSpaDzRKhCNEch/6BI6RfoQ6UjYHSjijHIMZ3uFe9jhWkPHc2 PM1KDVKdIzPtEmqpWnnGEkY8tXH6PFnMwGzbe2GxYDrh2rYLT3ZjFWYDdcrFC4cFbHzn 4jORE93nI+wCAIPpFIE6gJN/sySxronxRCyhEiM8wGeWZrhX0P24HyuzNcDDyfl6ZF6G mST4tggSkwtYsCI38+e5B+y8bSbUrZtbnZIBHkJ4mLozCNHnBLsepg7GKU401SX2cE/e Qtgw== X-Gm-Message-State: AOAM531Jth+EzT7fiFlYS0YVIv42i8l03RgbdI/VwSKNR/RjfFvnWzew QJCycLrWoDcHx4GHTCSmGEs= X-Google-Smtp-Source: ABdhPJyUDw18ja8j8msq6a/r+TNZZYa6WA5xFGvoIGPeDfYYeWwd0pmD5Dm9ojNH0tD9rHlUekaTYA== X-Received: by 2002:a1c:6384:: with SMTP id x126mr44064173wmb.144.1593939457351; Sun, 05 Jul 2020 01:57:37 -0700 (PDT) Original-Received: from my-little-tumbleweed (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id r1sm18755779wrw.24.2020.07.05.01.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2020 01:57:36 -0700 (PDT) In-Reply-To: <83o8ouu200.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 05 Jul 2020 05:30:55 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182731 Archived-At: Eli Zaretskii writes: >> From: K=C3=A9vin Le Gouguec >> Cc: egh@e6h.org, 42184@debbugs.gnu.org, Nicolas Goaziou >> , Bastien >> Date: Sat, 04 Jul 2020 21:52:08 +0200 >>=20 >> To make the discussion more concrete: here's a suggested patch for Org >> against the emacs-27 branch; what say you? > > I don't understand why you extend all those faces: the original report > was about a much smaller set. It is not the intent that every face > that happens to span the entire line be extended: that's why we made > ':extend' by default be off for a face. > > What am I missing? The original report was about the org-level-1 and org-level-2 faces, as well as org-block-begin-line and the org-block-end-line. The only faces I added were org-level-[3-8], because I don't see why different heading levels should not work with org-fontify-whole-heading-line. AFAICT, this is the simplest way to fix org-fontify-whole-heading-line and org-fontify-whole-block-delimiter-line for Emacs =E2=89=A527. These us= er options work under the assumption that simply fontifying the final newline is enough to extend attributes past EOL. The long term fix might be for Org to (1) deprecate these user options and let themes and/or users apply :extend t themselves, or (2) slap :extend t onto the faces when setting up the major mode fontification depending on these user options (Org already does similar on-the-fly face tweaks; see e.g. org-hide). Or something else. It seems to me that this kind of change would be somewhat more involved and breakage-prone, but if Org maintainers think this is the way forward for emacs-27, I wouldn't mind.