From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sebastian Fieber Newsgroups: gmane.emacs.bugs Subject: bug#40397: 28.0.50; epg decrypt does not verify signed content in smime Date: Sun, 02 Aug 2020 22:11:20 +0200 Message-ID: <87bljsajvb.fsf@web.de> References: <87imih5am2.fsf@web.de> <87r1x4dujl.fsf@web.de> <87lfna22eh.fsf@web.de> <874ktxtr6d.fsf@web.de> <87d08lh0qa.fsf@gmail.com> <87wo6tayhy.fsf@web.de> <85r1x0mv6q.fsf@gmail.com> <87h7xv9k3x.fsf@web.de> <873655oaa5.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2506"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40397@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 02 22:12:31 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2KLO-0000YK-Vy for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Aug 2020 22:12:30 +0200 Original-Received: from localhost ([::1]:49786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2KLN-0007s7-Jx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Aug 2020 16:12:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2KKw-0007rm-5W for bug-gnu-emacs@gnu.org; Sun, 02 Aug 2020 16:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k2KKv-0006yj-TE for bug-gnu-emacs@gnu.org; Sun, 02 Aug 2020 16:12:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k2KKv-0002AS-MS; Sun, 02 Aug 2020 16:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sebastian Fieber Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 02 Aug 2020 20:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40397 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 40397-submit@debbugs.gnu.org id=B40397.15963990928294 (code B ref 40397); Sun, 02 Aug 2020 20:12:01 +0000 Original-Received: (at 40397) by debbugs.gnu.org; 2 Aug 2020 20:11:32 +0000 Original-Received: from localhost ([127.0.0.1]:43552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2KKS-00029i-EG for submit@debbugs.gnu.org; Sun, 02 Aug 2020 16:11:32 -0400 Original-Received: from mout.web.de ([212.227.17.11]:49613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2KKO-00029S-GH for 40397@debbugs.gnu.org; Sun, 02 Aug 2020 16:11:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1596399081; bh=F8ZKzFGz5WQKLKwWzgpikpok6mAhWVsg6yX6dRxqhd4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=O0jRj8miG4HqFkX12bl7Fmos1WfnA5LA0o6Vwn2/POQ7v64ZMMyrI/O4FVeOgKRnv QOx1WjwMnjaZQDkobdgz4uCQzDviRNiz3EDcGJVBqDTCXleus0pe8hBC+ejFrBKi/E JwyLzn3lO/Z0BtL37jZsZiQ6OHm/pQgZ7uxEPaf8= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from comedian ([80.187.110.190]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N62uQ-1kr8aX2L72-016UpT; Sun, 02 Aug 2020 22:11:21 +0200 In-Reply-To: <873655oaa5.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 02 Aug 2020 08:02:26 +0200") X-Provags-ID: V03:K1:RKGYAGkpekoJlYVx7ccxhZWNpR2vknkFpS7u5Xw8Jcnr9HswUB+ Vt7X85B3DiQykchNRk3XZ3G7QxdpV2pZvnNLMEqzadFhC2VmfzPzMipdOxbYzlmJDr++hFO zk+wTVi+wfBJ6p5Iyl4qSqjSBJo1E41NqkOx5XbKL1PciA8MUhSGyJ18Hohg+ont1Wq4qYc 1Zu/gaXEToBqvCOzg1erA== X-UI-Out-Filterresults: notjunk:1;V03:K0:4u3gXgoLdJs=:3I5Qx7eg36xgqOhwyZD6Uf tWJRB+tm/B8BTQ9AQiMABkvx6ErcTSYtLk/t9wHYXmt3trZ1T52Z0FiUlni2fdfzZ1lFAmmnG Uz9LmnAjHgNL+y8ya2ElxtQpvlK/4+09yiH8WEmhLNAnvIkzchJ3FYMJo/6QYbrVNR4vaYQ6q JO4xSIEdsSF+rqge38mZXnub80SKnG8VjfRu8j/bP+woyIZ+/pTnHjsBHzFlS8qy/wu0Z90PX GzI1ywFFBekM4X/uD8KRgSpOmjusKPOA0oDXH26wDsCUgqf0/F2MdTBvXWxAHFWlFpNr+EGtf wfl6b2/d34Su/ArxrzMOQnZ6OUcTJOKgzw5KEq6qKkqZZ/EGc0qrAslYCiGby3aZItcVKw7yW /xBAnnYGm3JJuk7bWdaxvT0pR8rk0EDyQ1jryfBxX0pSAt5g8FuQxjup0YcsqTrc6e35iicB5 hqKH6+Hm7vfrk9xKia3VU1ie06DEd6mCYx+GC6LqmIt7o9CHbt8bOH/IPqxqAL8wBukqAR6E5 wnSvNBkYHfpzZ7UNRrZjxCDLpSLy+j9NQsdpV3SIdPhta0ZyqLgA0GIbh5wugU7D4akjMoOtc /fDYFMdjvgo/uqqtlSBUaWcKY/f6b3JkyiMDUCnMSyFe8gRenkCveVjqsqIfJ+AQgo6rhz2mq i9TI5Ij0HiWsPUIKkCoTYg+1x8Rvo8P6rKcMKHClOPGxsCDPfCi7Np/pXirOl+tTnTLxNf2R/ zMW5z6iwy7yaY96UKbCFsCibGPgXhIV+ALg6jKAU2G+C482qok4vCLA0rCbWPuAXoE3wsTCB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183886 Archived-At: On So, Aug 02 2020, Lars Ingebrigtsen wrote: >> and also does >> implement support for the security buttons for application/pkcs7-mime >> parts. This is quite nice as application/pkcs7-mime parts are not >> handled automatically by default in gnus. ATM you have to set >> mm-decrypt-option and mm-verify-option at least to 'ask. So with this >> supported it should now work out of the box even without setting >> mm-decrypt-option and mm-verify-option because now gnus shows the >> buttons properly and one can click on them and decrypt/verify the part >> "manually". > > This sounds like a good addition to me, and would like to apply the > patch to Emacs 28. It's a large patch, though, and you don't seem to > have copyright FSF assignment on file -- is that correct? If it is, > would you be willing to sign such paperwork, and we can then apply the > patch? Yes, I haven't done any copyright assignment yet but I'd be willing to do so if someone can guide me a bit or point me to where I can find info about what I have to do. There are some untested and unimplemented stuff in my implementation. If I remember correct there is no real handling of error cases which I wanted to add so it is on par with the other security buttons implementations. So I'd like to work on this a bit more and provide a more fully featured patch. But I'm pretty busy right now with real life, so this may take a few months as I'd need to find some time. Nontheless I will check if I have done any changes to my provided patch and resubmit it if I have any work pending - if you don't want to wait for me and want to apply the patch anyway even without proper error handling.