From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] [minimap] Fix minimap-kill when there is no timer object Date: Sun, 13 Sep 2020 16:13:11 +0200 Message-ID: <87bli9wyrs.fsf@gnus.org> References: <20200913112324.6088-1-emacs@adamspiers.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9515"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Adam Spiers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 13 16:14:00 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHSlT-0002ME-GF for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 16:13:59 +0200 Original-Received: from localhost ([::1]:37004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHSlS-00078B-It for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 10:13:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHSko-0006jJ-Ej for emacs-devel@gnu.org; Sun, 13 Sep 2020 10:13:18 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:35412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHSkm-0003Wd-VD for emacs-devel@gnu.org; Sun, 13 Sep 2020 10:13:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=W7X4OUAm/y9GCDZVOEU4x601Qei5jphmyODVldL9R4I=; b=EuFXVRmIWC84xaCTwwX0rBoCeS FRWdiVZKbtQA3cehkq+J+O8wvDnqIMl1nifQTaoxi/LbpekUvhiMw79LOe3+mX5uD8wfiXOkWzb10 UlWTf/yPzT/tcVAtKK9xgp6S4MHIRIf5NEApnaiWofFdWxSCTm6jot+qr9NbDcmb9Eao=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHSki-0003kH-LE; Sun, 13 Sep 2020 16:13:15 +0200 X-Now-Playing: KiTsuNe and Brian the Fox's _The Future Eve_: "(untitled)" In-Reply-To: <20200913112324.6088-1-emacs@adamspiers.org> (Adam Spiers's message of "Sun, 13 Sep 2020 12:23:24 +0100") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255482 Archived-At: Adam Spiers writes: > Occasionally minimap-timer-object can be nil when minimap-killer > is triggered. In this case, the following error is triggered: > > cancel-timer: Wrong type argument: timerp, nil > > So defensively check whether there is a timer to cancel before trying > to cancel it. Thanks; applied to the minimap package. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no