From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: haj@posteo.de (Harald =?UTF-8?Q?J=C3=B6rg?=) Newsgroups: gmane.emacs.bugs Subject: bug#46889: cperl-mode: Fix indentation issues [PATCH] Date: Tue, 09 Mar 2021 18:06:34 +0100 Message-ID: <87blbs9rz9.fsf@hajtower> References: <87im68uwld.fsf@hajtower> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16450"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) To: 46889@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 09 20:09:02 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJhj3-0004BL-Tk for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 20:09:01 +0100 Original-Received: from localhost ([::1]:38606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJhj2-0005wt-NH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 14:09:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJfp0-0006cp-Ma for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36285) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJfp0-00014W-EO for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJfp0-00043W-9Z for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: haj@posteo.de (Harald =?UTF-8?Q?J=C3=B6rg?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Mar 2021 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46889 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46889-submit@debbugs.gnu.org id=B46889.161530960615566 (code B ref 46889); Tue, 09 Mar 2021 17:07:02 +0000 Original-Received: (at 46889) by debbugs.gnu.org; 9 Mar 2021 17:06:46 +0000 Original-Received: from localhost ([127.0.0.1]:47831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJfoj-000430-O8 for submit@debbugs.gnu.org; Tue, 09 Mar 2021 12:06:45 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:50195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJfog-00042l-Kd for 46889@debbugs.gnu.org; Tue, 09 Mar 2021 12:06:45 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 279CD160061 for <46889@debbugs.gnu.org>; Tue, 9 Mar 2021 18:06:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1615309596; bh=DuA8elzW4J7Gp7L8L6mamtNuBx+QbByLNRTe1p61dtQ=; h=From:To:Subject:Date:From; b=TGq7qL4Je9XgdE8ZAmqA7bu7A2Rc/ScWA+cdAVaFoN32DoyFJENqZxCUgvVexDZ0U MhBlmfwS5n2q8LFYUo9/fUn5Ytinz+Z1wTO+LGet7e+iKYKBfCYyvKHrPt38N54wMn 4ntAxgoy2b3TifTyD+QNbQJMuMnXOHosQfMpRH4biNITjfkqvvKAa1pm0/d+7ukyrh rRX4eSW5kg/33iHl4LFdAqE0XlfAX5971ZvVDYXJozjX+47s5HOa6/da9irpgh2tS5 8/ZUSVPMdJEa95Ie7zC9R4/XwG0CMjqCyFI9JypMr8ZG5h/SukuLE5LJ18h2NCGsuO /VCaGgTqYRBMA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Dw1p3323Lz6tmS for <46889@debbugs.gnu.org>; Tue, 9 Mar 2021 18:06:35 +0100 (CET) In-Reply-To: <87im68uwld.fsf@hajtower> ("Harald \=\?utf-8\?Q\?J\=C3\=B6rg\=22's\?\= message of "Wed, 03 Mar 2021 15:43:10 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201926 Archived-At: haj@posteo.de (Harald J=C3=B6rg) writes: > Hello Emacs-Maintainers, > > this started out as working on Bug#42169 but it soon became clear that > there's more lurking in CPerl mode's indentation code, so I decided to > open a new issue here. > > In 7b2448ae (cperl-mode: Improve detection of index entries for imenu), > committed on Feb 17, the imenu part of Bug#42169 has been fixed. This > commit now fixes the indentation after a package which brings its own > block. > > Therefore, the patch in this report should finally fix Bug#42169. > > As a by-catch, the new code fixes the ancient Bug#8077. > > This patch also fixes the first part of Bug#11733. The "other > indentation bug" reported in Bug#11733 (using a colon as a Perl regexp > terminator) is a different story and not covered by this patch. > > Also fixed now (without known bug number): labels with a space before, > or a comment after the colon are now correctly indented and fontified. > > With this patch in effect, CPerl mode should finally have caught up with > Perl 5.30! > > Many thanks to Mattias Engdeg=C3=A5rd for his patient explanations how rx > expressions can be used without breaking compatibility to Emacs 26.1. > Until now, this allowed two ugly regexp literals to be eliminated.