From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39687: 26.3; Add customize-variable option for not locking keyboards Date: Wed, 21 Jul 2021 17:57:44 +0200 Message-ID: <87bl6vpslj.fsf@gnus.org> References: <3a518d18-cc99-195b-42a9-adc8ef764d67@lp-programming.com> <83mu9cjqml.fsf@gnu.org> <32ea14fb-1ab8-186e-2534-4d3d2a56d6d8@lp-programming.com> <83pne7hsyp.fsf@gnu.org> <6a23af03-d597-6e3e-ceb4-5fb1305a496a@lp-programming.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38691"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39687@debbugs.gnu.org To: Logan Perkins Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 21 17:59:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6Ecn-0009pq-C7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 17:59:09 +0200 Original-Received: from localhost ([::1]:57464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Ecm-0002NU-CJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 11:59:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6Ecg-0002NE-Ik for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 11:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6Ecg-000183-Az for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 11:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6Ecg-0000wb-BW for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 11:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jul 2021 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39687 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39687-submit@debbugs.gnu.org id=B39687.16268830833543 (code B ref 39687); Wed, 21 Jul 2021 15:59:02 +0000 Original-Received: (at 39687) by debbugs.gnu.org; 21 Jul 2021 15:58:03 +0000 Original-Received: from localhost ([127.0.0.1]:38404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Ebj-0000v4-6f for submit@debbugs.gnu.org; Wed, 21 Jul 2021 11:58:03 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:44248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Ebe-0000u6-Q7 for 39687@debbugs.gnu.org; Wed, 21 Jul 2021 11:57:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gRpLk7n4E9s12G0qSzkzSRsUr4WEdd3cXGo3WUzJhOE=; b=V97QfvvYLmln4Ex4NBPnoN9gP3 b0kdgaRMGq7utr/IAqelF0PEDrxBuaX73uFj4hsJskfrlCBK3z0OossSSNiXBiQerufuzVNI7Ou/Z on0kb0zU/kHa6lY3/txMojwfGYB5Xf9c7H9yMh4pq7id+Rkl3qmISz6k14dqMENLQHHY=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6EbQ-00082t-K6; Wed, 21 Jul 2021 17:57:47 +0200 X-Now-Playing: Coil's _The Restitution of Decayed Intelligence_: "A List Of Wishes" In-Reply-To: <6a23af03-d597-6e3e-ceb4-5fb1305a496a@lp-programming.com> (Logan Perkins's message of "Mon, 18 May 2020 18:15:15 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210461 Archived-At: Logan Perkins writes: > I *think* I have a patch that still fixes the current behavior, and > does not reintroduce those two bugs, I've included it below. > Basically, the fix for Bug#5095 should only be applied if we are in > the right context. If we're not, the if block above puts a > Qswitch_frame at the head of the side queue and triggers > replay_entire_sequence, so we just skip the second check. It'll get > run again and catch the interruption on the next pass, but in the > right context. I tried the various test cases, and the behaviour with your patch clearly seems better to me, so I've applied it to Emacs 28. But as Eli says, this is a ticklish area, so if this (re-)introduces other bugs, we'll have to revert. This change was small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no