From: Thierry Volpiatto <thievol@posteo.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 50508@debbugs.gnu.org
Subject: bug#50508: 27.2; find-function ignore find-function-source-path
Date: Mon, 13 Sep 2021 15:24:24 +0000 [thread overview]
Message-ID: <87bl4wze9h.fsf@posteo.net> (raw)
In-Reply-To: <87ilz4j4qk.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Thierry Volpiatto <thievol@posteo.net> writes:
>
>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>>
>>> 2) If the function was defined in a .el file (as this bug report
>>> describes), then Emacs knows the name of the library. But it doesn't
>>> then use `find-library-name' to locate the library, but just uses
>>> load-history. Fixing this is pretty easy -- just use
>>> `find-library-name' and use that instead of the value from
>>> `load-history'.
>>
>> Yes, this is working fine, it is what I am using actually.
>> https://github.com/emacs-helm/helm/blob/master/helm-lib.el#L1230
>
> I'm just wondering whether it makes sense to fix 2) if we're not fixing
> 1), and I don't think fixing 1) is a good idea (it'd make the function
> massively slower).
>
> Instead I'm wondering whether we should just fix the doc strings here to
> not mention `find-function-source-path' in `find-function' (etc), so
> that the doc string matches the implementation, and instead mention
> `find-library-name' (in the doc string) for your use case.
Yes sure, that's ok for me, I was just surprized to not be able to
let-bound `find-function-source-path` and run find-function just after
with the expected effect described in docstring, once you know it, you
can just write a function using `find-library-name` like I did.
Thanks.
--
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 686 bytes --]
next prev parent reply other threads:[~2021-09-13 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 12:13 bug#50508: 27.2; find-function ignore find-function-source-path Thierry Volpiatto
2021-09-11 13:31 ` Lars Ingebrigtsen
2021-09-11 16:29 ` Thierry Volpiatto
2021-09-13 7:48 ` Lars Ingebrigtsen
2021-09-13 15:24 ` Thierry Volpiatto [this message]
2021-09-14 11:45 ` Lars Ingebrigtsen
2021-09-14 17:24 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl4wze9h.fsf@posteo.net \
--to=thievol@posteo.net \
--cc=50508@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.