From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#32210: Support medium weighted fonts Date: Thu, 21 Oct 2021 14:49:56 +0200 Message-ID: <87bl3ih79n.fsf@gnus.org> References: <87v9riaofa.fsf@gnus.org> <83pnhq5w92.fsf@gnu.org> <87lfse5t5g.fsf@gnus.org> <835zji5qyn.fsf@gnu.org> <87k17xqxzy.fsf@gnus.org> <87eey5qxeh.fsf@gnus.org> <835zjh4243.fsf@gnu.org> <871ru5qf2w.fsf@gnus.org> <83muct2izq.fsf@gnu.org> <87r224nukh.fsf@gnus.org> <87lf2nn997.fsf@gnus.org> <838rync04b.fsf@gnu.org> <87h7dbn886.fsf@gnus.org> <834k9bbwz4.fsf@gnu.org> <87a6j3n52u.fsf@gnus.org> <875ytrn4fq.fsf@gnus.org> <8335ovbrp1.fsf@gnu.org> <875ytrksxe.fsf@gnus.org> <83bl3iamkf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21425"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: carlosjosepita@gmail.com, 32210@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 21 14:51:38 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdXXm-0005KD-LT for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 14:51:38 +0200 Original-Received: from localhost ([::1]:36546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdXXl-0002js-Ci for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 08:51:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdXXC-0002if-H3 for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 08:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdXXC-0004ao-6u for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 08:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdXXC-0007mT-3o for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 08:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Oct 2021 12:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32210 X-GNU-PR-Package: emacs Original-Received: via spool by 32210-submit@debbugs.gnu.org id=B32210.163482061129811 (code B ref 32210); Thu, 21 Oct 2021 12:51:02 +0000 Original-Received: (at 32210) by debbugs.gnu.org; 21 Oct 2021 12:50:11 +0000 Original-Received: from localhost ([127.0.0.1]:56451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdXWM-0007kj-NT for submit@debbugs.gnu.org; Thu, 21 Oct 2021 08:50:10 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdXWJ-0007k9-Rz for 32210@debbugs.gnu.org; Thu, 21 Oct 2021 08:50:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+l+Igz/XbsixEEvvvsfOo5PzCBGTKR8e8VAiXixSd1s=; b=R8hJl6ajFXcLgqepfDiiUfYQDc F6rfxynXY0TB8zWDV/0oeQzXKnjAqonXMRSuWdq4pIqHVseP0wV+l++rrm46zHkRJlIkO2ZNudfZW WYLfsW9i4iCW6xuEZTWq9IhcOnCwfbOns6VJwNCYMI9fRTM4MiOG63iWqGYsVtkzzH7s=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdXW8-0001EM-U8; Thu, 21 Oct 2021 14:50:00 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEVmtfJ/f423y8+b X1lLLzj///8Z8KpJAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UKFQQgFC99x54AAAFtSURBVDjLrdNR koMgDAZg0B6AQA6g0AMI4QBlyf3PtIFWq6u7MzvT/6Ez8DUkjKrUB6ONVtYPRgNYDQPADBasQC7B xjgso+OCGbgiW+ZJ6RTmuICKY3NtgnFzSsEoHUFlExXAHWwBM6rs5oICnA2qOLiI1WT6CvITapHe kxTLQfAYp+j9MspRkKJAwckpQFhGKOQE0NkH9qmUU5mtCTWOVUkF2WWc1tsM5/vBFjP4wb8iEKiF mWjx78gF5/ZnJK5gnnvzD+DSwa4VQwPnmLkuPgD0g2kFcDk3kLSWmd9AvAPeVVSB3uN4lOO8VvSC vE6FlV49glxIBmnQTsp91eBek897kAWXBpYS7oE7gA+eEj17NOAXtFnbxCe4V6JAvo97AEcyXkwb uDdIEm2AB6ALuGfZrCsQbbA9pwa8pRwe7e0vKHiC9fU5vlKyNp/8BH//Nk+t18iYl/s3Bj7NphuU hI/rCj5X9CBe9/h3vgHNwHGMbot6eAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0xMC0yMVQwNDoz MjoyMCswMDowMBsM4/UAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMTAtMjFUMDQ6MzI6MjArMDA6 MDBqUVtJAAAAAElFTkSuQmCC X-Now-Playing: You Make Me Feel (Mighty Real)'s _Sylvester-Step II_: "epilogue" In-Reply-To: <83bl3iamkf.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Oct 2021 10:01:20 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217764 Archived-At: Eli Zaretskii writes: >> static const struct table_entry weight_table[] = >> { >> { 0, { "thin" }}, >> - { 20, { "ultra-light", "ultralight" }}, >> - { 40, { "extra-light", "extralight" }}, >> + { 40, { "ultra-light", "ultralight", "extra-light", "extralight" }}, > > This loses the distinction between ultra-light and extra-light. Are > these two really indistinguishable in all supported font backends? I added them together because the Gtk documentation (and the Windows one, I think? I've been working on this for a while, and some of the details are vague) said that there's only one weight between "light" and "thin", so people specifying "ultra-light" wouldn't actually get it, because 20 is too far from being correct. I fc-queried all the 1K fonts on this system, and indeed -- none of them had a weight of 20. There were weights at 0 and 40, though (and none inbetween). So I'm as confident about that change as... er... well, it's font stuff, so I'm not confident at all, but I think it's worth a try. I'll test this stuff on FreeBSD and see what it says there, once I get the VMs up again on my new VM machine. >> static Lisp_Object >> w32_to_fc_weight (int n) >> { >> - if (n >= FW_HEAVY) return intern ("black"); >> + if (n >= FW_HEAVY) return Qbold; >> if (n >= FW_EXTRABOLD) return Qextra_bold; > > This doesn't look right. Should that Qbold be Qblack? Good catch. Now fixed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no