Re: master 89365d7: Fix mouse buttons in dired--make-directory-clickable

Re: master 89365d7: Fix mouse buttons in dired--make-directory-clickable

[Stefan Kangas]

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit 89365d748f15f2fd789c3818480a16849ac05a94
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Fix mouse buttons in dired--make-directory-clickable
>
>     * lisp/dired.el (dired--make-directory-clickable): Adjust mouse
>     clicks to conform to our standards.
> ---
>  lisp/dired.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/dired.el b/lisp/dired.el
> index ced1811..40dfc39 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -1672,7 +1672,8 @@ see `dired-use-ls-dired' for more details.")
>                                            (dired-goto-subdir current-dir)
>                                          (dired current-dir)))))
>                          (define-keymap
> -                          [down-mouse-1] click
> +                          [mouse-2] click
> +                          [follow-link] 'mouse-face

AFAICT, our standards are to follow links on mouse-1.  This happens in
eww, help-mode, etc.

Re: master 89365d7: Fix mouse buttons in dired--make-directory-clickable

[Lars Ingebrigtsen]

Stefan Kangas <stefankangas@gmail.com> writes:

>> -                          [down-mouse-1] click
>> +                          [mouse-2] click
>> +                          [follow-link] 'mouse-face
>
> AFAICT, our standards are to follow links on mouse-1.  This happens in
> eww, help-mode, etc.

Yes, that's what this magical incantation does (in conjunction with
the mouse-1-click-follows-link user option).  I think?  Or has this
changed again?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

RE: [External] : Re: master 89365d7: Fix mouse buttons in dired--make-directory-clickable

[Drew Adams]

> AFAICT, our standards are to follow links on mouse-1.  This happens in
> eww, help-mode, etc.

(Not really.  That's done by default, but it doesn't
express our standards.  Our standards are to respect
user option `mouse-1-click-follows-link'.)

Re: master 89365d7: Fix mouse buttons in dired--make-directory-clickable

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>>> -                          [down-mouse-1] click
>>> +                          [mouse-2] click
>>> +                          [follow-link] 'mouse-face
>>
>> AFAICT, our standards are to follow links on mouse-1.  This happens in
>> eww, help-mode, etc.
>
> Yes, that's what this magical incantation does (in conjunction with
> the mouse-1-click-follows-link user option).  I think?  Or has this
> changed again?

Aha!  Yes, it works as it should.  Please ignore me, carry on.