all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 54060@debbugs.gnu.org
Subject: bug#54060: 29.0.50; diff-buffers should take narrowing into account
Date: Sat, 19 Feb 2022 13:29:23 +0100	[thread overview]
Message-ID: <87bkz3xcnw.fsf@gnus.org> (raw)
In-Reply-To: <wvr4v8xcnj5u.fsf@gmail.com> (Philipp Stephani's message of "Fri,  18 Feb 2022 19:06:53 +0100")

Philipp Stephani <p.stephani2@gmail.com> writes:

> Unlike ediff-buffers, diff-buffers always compares the entire buffer
> contents, not the accessible portion.  I think it would be better to
> restrict the diff to the accessible portion, since normally buffer
> commands only act on the accessible portion (and the capability to
> compare only portions of buffers is occasionally quite useful!).

Makes sense to me, but I rarely use diff-buffers, so I don't really know
what the expectations are.  

> IIUC the only change needed would be to replace (write-region nil nil
> ...)  in diff-file-local-copy with (write-region (point-min)
> (point-max) ...).  If we don't want to change the default behavior,
> then this could be made configurable with a customization option.

I think it would make sense to change the default behaviour, but perhaps
have an option to switch it back to the old behaviour.

Any opinions?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-02-19 12:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 18:06 bug#54060: 29.0.50; diff-buffers should take narrowing into account Philipp Stephani
2022-02-19 12:29 ` Lars Ingebrigtsen [this message]
2022-03-21 18:29   ` Lars Ingebrigtsen
2022-03-21 22:31   ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkz3xcnw.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=54060@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.