From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#54161: 27.2; `define-minor-mode' with alist of key bindings Date: Tue, 01 Mar 2022 02:21:32 +0100 Message-ID: <87bkyqmpr7.fsf@web.de> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30798"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54161@debbugs.gnu.org To: Gilles Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 01 02:22:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOrDO-0007sw-4A for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Mar 2022 02:22:10 +0100 Original-Received: from localhost ([::1]:36206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOrDM-0004aR-OF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 20:22:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOrDG-0004aJ-7G for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 20:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41121) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOrDF-0005Cn-VI for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 20:22:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOrDF-0003SN-RW for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 20:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Mar 2022 01:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54161 X-GNU-PR-Package: emacs Original-Received: via spool by 54161-submit@debbugs.gnu.org id=B54161.164609770213259 (code B ref 54161); Tue, 01 Mar 2022 01:22:01 +0000 Original-Received: (at 54161) by debbugs.gnu.org; 1 Mar 2022 01:21:42 +0000 Original-Received: from localhost ([127.0.0.1]:35018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOrCw-0003Rn-FK for submit@debbugs.gnu.org; Mon, 28 Feb 2022 20:21:42 -0500 Original-Received: from mout.web.de ([212.227.17.12]:33775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOrCu-0003RY-Nq for 54161@debbugs.gnu.org; Mon, 28 Feb 2022 20:21:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1646097693; bh=2i1vvmoWvieYvEp43ndlrGFiuCQVyjs9gUaREZEA9ow=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=mgZn8PixsKu63zFBHP08yHnxTjpzH+/VJk9wkb41Sb3ERG6Nu0+LBRNs8vn1BVnQW AtPAIKIiCrUDiUrHNTriCAYXPlpyqsszc2iUamGKFVqzYDYpl6tls8iF8KjCB1NL3O mu+3OmAMDXJ4zFJT6n8zT07XgWzceehhUYPO+LKA= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1Mdf8F-1nxuuK2lO5-00ZceB; Tue, 01 Mar 2022 02:21:33 +0100 In-Reply-To: (Gilles's message of "Fri, 25 Feb 2022 22:41:05 +0100") X-Provags-ID: V03:K1:EC1+8JEyCfUida9FlGcxLV1ZtmWmZ8bRz209nS8u3EYH+/yHCBs iyTrkp+WpLULovgH+dKLwJh1L1Fa976M7iXU1bsR5qsogn1yi3GdZBaxqCEuKgygk86gbjW UVnFjsn0Uovhxaaswik61DTDMDFPrmd4zDr8LdOU/r1UFohsEiA70xLZicbc9yL+Lm8lPbp KoW2/QhLF+4t3rZpmXsqw== X-UI-Out-Filterresults: notjunk:1;V03:K0:YeBZJ5wmhcs=:yJYQdm34JQxoY/NQTdgQv0 ZvyueqLP9KC/USLkeU3ncwU+pllnVlP2WRVITN4Svv1L0VJdlW6YsY73TuETTzbAABj52AdAT w1qj0kB6SpoRQlnV+G6QnitZJE4hj2z9mDEkKBerz4MLcgKA2WuqUjACaw+2XwuEL5vAHHPq8 ddsyN/2/isfU2txe+qhaSa6adu0ol0RJIKqa/gLbe9L8aY/7kLVWoNj1DXWd5BPl0iSAV9pJu 6mYebxmZUN5JXaoHGIeR49qQdn8goZMAXHf9r3R55NSV6EaXvvqoRzcK9I4o6khzUsvx4aGJA sFHriwQ9Qp05v0GeWZ7RkBuwlVlI/eJtmjJW3Z8namONsHFvUkvElNOg++BDB3JYedsMOpANz Dr07lDD/26h1Vn2ZmywTNxuVZoJPBvy1UNawg827FA3NQkULWjWnuTbmMPMbpmYxtcVNzxqR8 7/rGN65Zr+UP8aaMCXUn9W26NpaxBNhmEPiWGvZv3SKK4JEf7xqwBuvbC+SXXZQwsGadDbCoT UUJe5AMFaniYjiafSMlCFZ/7euDOk+2sL//sDW8UA8fv1+lIkHypagThCWaKsdI3akMJKs4Tb 2zsn0YD52PigH6X+AqMhWMnOlkQzjj3RNTg3CNQsPU8feQXJjoRMtpN1TxRH40gWMjiazjpCY N0qXrhQK86AhlCsi8ijTQnyISsSmb+DThtbVj7EW4jZ7viVtTJnkgeJ63WzK6HfkexJ3vcRZv 8ZS8VM8zr2hJ7ftyRaULoAM1jJCISJ7s8rqQgErR7dSwJeQ+BCPRwtyYeH//HtSiDrDRLcxz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227855 Archived-At: --=-=-= Content-Type: text/plain Gilles writes: > The Lisp *expression* (kbd "C-o") *returns* a suitable argument for > define-key. I think the small source of confusion is whether these arguments are evaluated. How about making that clearer, e.g. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-WIP-Fix-54161.patch Content-Transfer-Encoding: quoted-printable =46rom 73283a3a37a7df41a0a1ab9d88bcf31704e9e841 Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Tue, 1 Mar 2022 02:13:14 +0100 Subject: [PATCH] WIP: Fix #54161 =2D-- lisp/emacs-lisp/easy-mmode.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el index 688c76e0c5..b35be58b3a 100644 =2D-- a/lisp/emacs-lisp/easy-mmode.el +++ b/lisp/emacs-lisp/easy-mmode.el @@ -168,9 +168,9 @@ define-minor-mode If non-nil, it should be an unquoted variable name (whose= value is a keymap), or an expression that returns either a keym= ap or a list of (KEY . BINDING) pairs where KEY and BINDING are - suitable for `define-key'. If you supply a KEYMAP argument - that is not a symbol, this macro defines the variable MODE-map - and gives it the value that KEYMAP specifies. + suitable values for `define-key'. If you supply a KEYMAP + argument that is not a symbol, this macro defines the + variable MODE-map and gives it the value that KEYMAP specifies. :interactive VAL Whether this mode should be a command or not. The defa= ult is to make it one; use nil to avoid that. If VAL is a li= st, it's interpreted as a list of major modes this minor mode =2D- 2.30.2 --=-=-= Content-Type: text/plain BTW, should we fix the mixed indentation style in these lines (tabs vs. spaces)? Michael. --=-=-=--