From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jai Flack Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: gnus-search-mu Date: Mon, 28 Mar 2022 18:22:45 +1000 Message-ID: <87bkxqa3l6.fsf@disroot.org> References: <87czib77uz.fsf@disroot.org> <878rszidk9.fsf@ericabrahamsen.net> <87sfr6eunp.fsf@disroot.org> <8735j5tzus.fsf@ericabrahamsen.net> <87ils0yqxd.fsf@disroot.org> <87ilrzuoof.fsf@ericabrahamsen.net> <87ilrz9d2x.fsf@disroot.org> <878rsuvie4.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34702"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 28 13:11:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYnHu-0008la-AY for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Mar 2022 13:11:54 +0200 Original-Received: from localhost ([::1]:34516 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYnHt-0007WN-0t for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Mar 2022 07:11:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYkfU-0006ru-3V for emacs-devel@gnu.org; Mon, 28 Mar 2022 04:24:04 -0400 Original-Received: from knopi.disroot.org ([178.21.23.139]:39996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYkfR-0008Gz-DF for emacs-devel@gnu.org; Mon, 28 Mar 2022 04:24:03 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 8950740182; Mon, 28 Mar 2022 10:23:57 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id Ao4aN0NpomXX; Mon, 28 Mar 2022 10:23:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1648455770; bh=372x/Oh4k64ZeAjkHTFrqdiUotpJiNAVdZKMgdARq+s=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=FRuyzs52iOWYqtubfjWdRXtHYdIjsU6ougtnCxWwz++0HMA0Hgd3esu3z4eRtyEgD np2nPHjnBdW72tMftdt75+I5PcjA//4bq3VKafT9zgYl4/CgXZcFKswxVTTwwExbju S8I6Wt/n+mk9FZo9mexHGyhEnbW2GONSpr99OxMhcgYs8r62P3nZgS84D0PnAbyRxs 7trTLWF0UiTeNFSPCzpAI7LBBX+ylM3fT0mMiw+xVE3aTR3E13LUxTa8HJqZPL8tzi ydqCdvp3vkoxDzzfsNt1KsmXi7e5FrGT6wVRwwZSVVQ6kzdQ5Rqlt5Xde3Tas432UO mj3Uy8tFz9Xyg== In-Reply-To: <878rsuvie4.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 27 Mar 2022 20:57:23 -0700") Received-SPF: pass client-ip=178.21.23.139; envelope-from=jflack@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 28 Mar 2022 07:07:52 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287523 Archived-At: Eric Abrahamsen writes: >> Were there any docstrings in particular you noticed that didn't make up >> a complete sentence? I've updated them to be (roughly) the same as the >> notmuch and namazu backends but the first lines already matched. > > Sorry, that was poorly phrased. I meant the first sentence of the docstring > should all fit on a single line. Like this: > > (defcustom gnus-search-mu-raw-queries-p nil > "If t, all mu engines will only accept raw search query > strings. > > This can also be set per-server." > :type 'boolean > :group 'gnus-search) > > The first sentence should be munged until it doesn't wrap, then the > second blank line doesn't need to be there. A la the "Tips for > Documentation Strings" section of the Elisp manual. Ah right. > (If gnus-search.el itself doesn't fully adhere to these conventions, > well... I'll get there eventually.) I also noticed some of the defcustom :types don't match (like `gnus-search-*-remove-prefix). Probably wouldn't save you any time writing a patch for these. >>>>> Out of curiosity, what is `ansi-color-filter-apply' doing there? >>>> >>>> I think I had trouble with mu giving ANSI escape codes to Emacs, it >>>> might no longer be a problem or maybe there is a better solution. >>> >>> Okay, sounds good! ansi-color is built in so there's no harm in that. >> >> I've changed this to use the --nocolor option for mu. > > Even better. > >>> I'm assuming you have done copyright assignment. Do you have push >>> permissions for ELPA and/or Emacs proper? >> >> Done copyright assignment. Don't have any push permissions. > > Are you expecting to ask for permission? (I'm not able to grant it.) If > not, I can push these things for you. I wasn't planning on asking for permission. Not sure about the process but I assume a bit more trust is required than a potential patch and a couple potential ELPA packages. >> For the ELPA package is there a good way to signal to users that the >> built-in version should be used on a recent-enough Emacs version? > > I think your current Package-Requires header is the best we can do. I > haven't actually tested if it will refuse to install on Emacs < 28.1, > but I think due diligence is done. Not sure if you misunderstood me, I meant a warning for Emacs > 28 when the mu backend will (hopefully) be a part of Emacs. Though it will possibly not like the current pretest 28.0.92 < 28.1. -- Thanks, Jai