From: Jai Flack <jflack@disroot.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] New package: gnus-search-mu
Date: Mon, 28 Mar 2022 18:22:45 +1000 [thread overview]
Message-ID: <87bkxqa3l6.fsf@disroot.org> (raw)
In-Reply-To: <878rsuvie4.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 27 Mar 2022 20:57:23 -0700")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>> Were there any docstrings in particular you noticed that didn't make up
>> a complete sentence? I've updated them to be (roughly) the same as the
>> notmuch and namazu backends but the first lines already matched.
>
> Sorry, that was poorly phrased. I meant the first sentence of the docstring
> should all fit on a single line. Like this:
>
> (defcustom gnus-search-mu-raw-queries-p nil
> "If t, all mu engines will only accept raw search query
> strings.
>
> This can also be set per-server."
> :type 'boolean
> :group 'gnus-search)
>
> The first sentence should be munged until it doesn't wrap, then the
> second blank line doesn't need to be there. A la the "Tips for
> Documentation Strings" section of the Elisp manual.
Ah right.
> (If gnus-search.el itself doesn't fully adhere to these conventions,
> well... I'll get there eventually.)
I also noticed some of the defcustom :types don't match (like
`gnus-search-*-remove-prefix). Probably wouldn't save you any time
writing a patch for these.
>>>>> Out of curiosity, what is `ansi-color-filter-apply' doing there?
>>>>
>>>> I think I had trouble with mu giving ANSI escape codes to Emacs, it
>>>> might no longer be a problem or maybe there is a better solution.
>>>
>>> Okay, sounds good! ansi-color is built in so there's no harm in that.
>>
>> I've changed this to use the --nocolor option for mu.
>
> Even better.
>
>>> I'm assuming you have done copyright assignment. Do you have push
>>> permissions for ELPA and/or Emacs proper?
>>
>> Done copyright assignment. Don't have any push permissions.
>
> Are you expecting to ask for permission? (I'm not able to grant it.) If
> not, I can push these things for you.
I wasn't planning on asking for permission. Not sure about the process
but I assume a bit more trust is required than a potential patch and a
couple potential ELPA packages.
>> For the ELPA package is there a good way to signal to users that the
>> built-in version should be used on a recent-enough Emacs version?
>
> I think your current Package-Requires header is the best we can do. I
> haven't actually tested if it will refuse to install on Emacs < 28.1,
> but I think due diligence is done.
Not sure if you misunderstood me, I meant a warning for Emacs > 28 when
the mu backend will (hopefully) be a part of Emacs.
Though it will possibly not like the current pretest 28.0.92 < 28.1.
--
Thanks,
Jai
next prev parent reply other threads:[~2022-03-28 8:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 14:17 [ELPA] New package: gnus-search-mu Jai Flack
2022-03-24 15:18 ` Eric Abrahamsen
2022-03-25 0:35 ` Jai Flack
2022-03-25 22:46 ` Eric Abrahamsen
2022-03-27 4:12 ` Jai Flack
2022-03-27 20:26 ` Eric Abrahamsen
2022-03-27 23:43 ` Jai Flack
2022-03-28 3:57 ` Eric Abrahamsen
2022-03-28 8:22 ` Jai Flack [this message]
2022-03-29 20:28 ` Eric Abrahamsen
2022-03-30 4:42 ` Jai Flack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkxqa3l6.fsf@disroot.org \
--to=jflack@disroot.org \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.