Re: master 28358db930 1/2: Fix loaddefs generation

Re: master 28358db930 1/2: Fix loaddefs generation

[Lars Ingebrigtsen]

Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

>                    (delete-region (match-beginning 0)
> -                                 (and (search-forward "\n\f\n;;;")
> +                                 (and (search-forward "\n\f\n;;;" nil t)
>                                        (match-beginning 0)))

That will make delete-region be called with a nil if the search-forward
fails.  But it shouldn't fail -- if it fails, there loaddefs file is
corrupted.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 28358db930 1/2: Fix loaddefs generation

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> But it shouldn't fail -- if it fails, there loaddefs file is
> corrupted.

Or there's old-style loaddefs.el files in there.  Sorry, I forgot to
mention that a "make bootstrap" or "make -C lisp autoloads-force" is
necessary after updating, unfortunately.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 28358db930 1/2: Fix loaddefs generation

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> That will make delete-region be called with a nil if the search-forward
> fails.  But it shouldn't fail -- if it fails, there loaddefs file is
> corrupted.

The build kept failing with a `search-failed' error before this change.
I don't know that code very well, but allowing it to fail did fix the
bug.

I'm not sure how to fix that properly.  Would it suffice to simply not
call `delete-region' should the search fail?

Re: master 28358db930 1/2: Fix loaddefs generation

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> The build kept failing with a `search-failed' error before this change.
> I don't know that code very well, but allowing it to fail did fix the
> bug.
>
> I'm not sure how to fix that properly.  Would it suffice to simply not
> call `delete-region' should the search fail?

The problem is with mixing old-style loaddefs files with new ones, so
the previous error was correct.  I've now tweaked the process so that it
should regenerate all the loaddefs files when loaddefs-gen changes.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 28358db930 1/2: Fix loaddefs generation

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> The problem is with mixing old-style loaddefs files with new ones, so
> the previous error was correct.  I've now tweaked the process so that it
> should regenerate all the loaddefs files when loaddefs-gen changes.

Thanks.