all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 28358db930 1/2: Fix loaddefs generation
Date: Wed, 01 Jun 2022 18:50:55 +0800	[thread overview]
Message-ID: <87bkvc8xo0.fsf@yahoo.com> (raw)
In-Reply-To: <875ylk3bqj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 01 Jun 2022 12:43:32 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> That will make delete-region be called with a nil if the search-forward
> fails.  But it shouldn't fail -- if it fails, there loaddefs file is
> corrupted.

The build kept failing with a `search-failed' error before this change.
I don't know that code very well, but allowing it to fail did fix the
bug.

I'm not sure how to fix that properly.  Would it suffice to simply not
call `delete-region' should the search fail?



  parent reply	other threads:[~2022-06-01 10:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165407915849.23252.1559301725793524980@vcs2.savannah.gnu.org>
     [not found] ` <20220601102558.E4719C05808@vcs2.savannah.gnu.org>
2022-06-01 10:43   ` master 28358db930 1/2: Fix loaddefs generation Lars Ingebrigtsen
2022-06-01 10:47     ` Lars Ingebrigtsen
2022-06-01 10:50     ` Po Lu [this message]
2022-06-01 10:57       ` Lars Ingebrigtsen
2022-06-01 10:59         ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkvc8xo0.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.