From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Reworking loaddefs.el generation Date: Wed, 01 Jun 2022 14:13:21 +0200 Message-ID: <87bkvc1t0e.fsf@gnus.org> References: <87ee0f8cvx.fsf@gnus.org> <87o7zd7ked.fsf@gnus.org> <87fskp7jbd.fsf@gnus.org> <874k157ie6.fsf@gnus.org> <87r14960bp.fsf@gnus.org> <83pmjth5du.fsf@gnu.org> <87czft4hvh.fsf@gnus.org> <83o7zdglva.fsf@gnu.org> <87zgix2k29.fsf@gnus.org> <83fskoharn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30256"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 01 14:14:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nwNFY-0007g1-GN for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Jun 2022 14:14:56 +0200 Original-Received: from localhost ([::1]:57902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwNFX-0005yP-Dw for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Jun 2022 08:14:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwNEB-0004Fi-Tp for emacs-devel@gnu.org; Wed, 01 Jun 2022 08:13:31 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:56692) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwNE7-0002m0-3t; Wed, 01 Jun 2022 08:13:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KckgY5Npl7zebWcJ6iSWU1IiGm7J1hlkH1d3ck9Lnuc=; b=HaOpFgg4Hd9UgD1stuWQgIxGlO /HQY0BGcxb6kD0JImLYuef7+SiRj0dwq86+6pyMAq1iPcNs2Jo9quKCOCyOo9fK+nyhejN8GdWxbe QPmbPvHkB0hgOKt506F06TFaJPcdIP5tx+DPVmkUZhoQaKHTEqvU8HismnDmSWvXkxpE=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nwNE2-0005Jp-CU; Wed, 01 Jun 2022 14:13:25 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEWcoqKgpqaQlZV9 gYFxdXT///91o9+9AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YGAQwIDPNA/70AAAG3SURBVDjLdZSN kesgDISFnAIwFYiVC3BECrjxpf+angQmz7lJmMkkw4d2V/yE0vpxFPoyMrHEN+Yg9g/ADr4pcTdJ Oeo+gDVA+gToS0V6W38BvpqhhvQHZEr8q9sBq1cQxvwr/HzW0up/QH2+Yns+UcvRMwboeTawwQFE 9wmSl/BxM8LDJGvVCDmlNtHDM0FFpdSLhxXZLHkMvXOyE/h8ubtFLEjZSl28gZI6WMwl+malxdPV dFasemtHD5dybrB9Sq1YsI9zy0m3ajkNkH9QhGScaZGKTAOUHywyD7uI6AtU0e7QQcVCA6RyILzR DNETNE2gDdxvSgiaaQ2dAC7F04N3LK+KCn3dNJbw8NsW4H5J5UAnyD9vIOJ2QMlY9wkU1WiCTQ9M YBrZB6AbTM89WUQ3eQG+K4/t5QfvF0BH8bZjXr3J/uMEN8Hez9wdeBcCYwA+XKoBRg/ZIEwTUNxO l/GizfhSQcV8W45Y3EYIhI3f9cRWC1C51bN/QgdOmku1JvkCxmvy56o450MqQO41a07rayt7UQf5 7f1Hg9L/B2j9C3B9rONZnx5fxjfAcQpDY/4PDDX+BzTdR/zouytYAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIyLTA2LTAxVDEyOjA4OjEyKzAwOjAwpMkwjgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0w Ni0wMVQxMjowODoxMiswMDowMNWUiDIAAAAASUVORK5CYII= X-Now-Playing: The Wake's _Harmony & Singles_: "An Immaculate Conception" In-Reply-To: <83fskoharn.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 01 Jun 2022 14:40:44 +0300") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290491 Archived-At: Eli Zaretskii writes: > I see this with the current master: > > $ touch lisp/array.el .git/logs/HEAD > $ make -j4 > [...] > GEN loaddefs.el > INFO Scraping files for loaddefs... > INFO Scraping files for loaddefs...26% > INFO Scraping files for loaddefs...53% > INFO Scraping files for loaddefs...81% > INFO Scraping files for loaddefs...done > GEN loaddefs.el > > Why so much "scraping" lines for just one file modified? I get GEN loaddefs.el INFO Scraping files for loaddefs... INFO Scraping files for loaddefs...done GEN loaddefs.el in that test case. The loop is: (dolist (file files) (progress-reporter-update progress (setq file-count (1+ file-count))) (when (or (not updating) (file-newer-than-file-p file output-file)) So it seems like file-newer-than-file-p is very slow on your machine since progress-reporter manages to output several percentages? > And the example which was before my eyes when I wrote the above was > actually this: [...] > GEN loaddefs.el > INFO Scraping files for loaddefs... > INFO Scraping files for loaddefs...10% > INFO Scraping files for loaddefs...20% > INFO Scraping files for loaddefs...30% > INFO Scraping files for loaddefs...40% [...] > ELC emacs-lisp/loaddefs-gen.elc Yes, when loaddefs-gen is newer than lisp/loaddefs.el, it regenerates all the loaddefs files (both to avoid problems with old-style loaddefs files and to force updates if there's a bug in loaddefs-gen itself). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no