all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Visuwesh <visuweshm@gmail.com>
To: 55977@debbugs.gnu.org
Subject: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message
Date: Tue, 14 Jun 2022 23:00:59 +0530	[thread overview]
Message-ID: <87bkuv2lv0.fsf@gmail.com> (raw)
In-Reply-To: <87fsk72m0b.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 17 bytes --]

Patch attached.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-repeat-mode-Don-t-echo-unset-keys-in-help-message.patch --]
[-- Type: text/x-diff, Size: 932 bytes --]

From 245b353ca178c633c8fffaf0375a9bba99ba1917 Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Tue, 14 Jun 2022 22:59:47 +0530
Subject: [PATCH] repeat-mode: Don't echo unset keys in help message

* repeat.el (repeat-echo-message-string): Check if the key is set.
(bug#55977)
---
 lisp/repeat.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/repeat.el b/lisp/repeat.el
index ea4e3d0bd8..94ea9f7ac1 100644
--- a/lisp/repeat.el
+++ b/lisp/repeat.el
@@ -500,7 +500,7 @@ repeat-post-hook
 (defun repeat-echo-message-string (keymap)
   "Return a string with a list of repeating keys."
   (let (keys)
-    (map-keymap (lambda (key _) (push key keys)) keymap)
+    (map-keymap (lambda (key cmd) (and cmd (push key keys))) keymap)
     (format-message "Repeat with %s%s"
                     (mapconcat (lambda (key)
                                  (key-description (vector key)))
-- 
2.35.1


  reply	other threads:[~2022-06-14 17:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 17:27 bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message Visuwesh
2022-06-14 17:30 ` Visuwesh [this message]
2022-06-14 17:40 ` Eli Zaretskii
2022-06-14 18:02   ` Visuwesh
2022-06-14 18:09     ` Visuwesh
2022-06-15  7:25       ` Juri Linkov
2022-06-15  7:36         ` Visuwesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkuv2lv0.fsf@gmail.com \
    --to=visuweshm@gmail.com \
    --cc=55977@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.