Re: master 1d681a5700: Add test for bug#56078 fix

Re: master 1d681a5700: Add test for bug#56078 fix

[Robert Pluim]

>>>>> On Mon, 20 Jun 2022 22:12:20 -0400 (EDT), Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:

 
    Po> +(ert-deftest dnd-tests-open-remote-url ()
    Po> +  ;; Expensive test to make sure opening an FTP URL during
    Po> +  ;; drag-and-drop works.
    Po> +  :tags '(:expensive-test)
    Po> +  ;; Don't run this test if the FTP server isn't reachable.
    Po> +  (skip-unless (and (fboundp 'network-lookup-address-info)
    Po> +                    (network-lookup-address-info "ftp.gnu.org")))
    Po> +  ;; Make sure bug#56078 doesn't happen again.
    Po> +  (let ((url "ftp://anonymous@ftp.gnu.org/")
    Po> +        ;; This prints a bunch of annoying spaces to stdout.
    Po> +        (inhibit-message t))
    Po> +    (should (prog1 t (dnd-open-remote-url url 'private)))))
    Po> +
    Po>  (provide 'dnd-tests)
    Po>  ;;; dnd-tests.el ends here

I thought that the test suite 'phoning home' was frowned upon (and
which platform doesnʼt have network-lookup-address-info?)

Robert
-- 

Re: master 1d681a5700: Add test for bug#56078 fix

[Po Lu]

Robert Pluim <rpluim@gmail.com> writes:

> I thought that the test suite 'phoning home' was frowned upon

Hmm, any better ideas?

> (and which platform doesnʼt have network-lookup-address-info?)

MS-DOS.

Re: master 1d681a5700: Add test for bug#56078 fix

[Robert Pluim]

>>>>> On Tue, 21 Jun 2022 18:16:21 +0800, Po Lu <luangruo@yahoo.com> said:

    Po> Robert Pluim <rpluim@gmail.com> writes:
    >> I thought that the test suite 'phoning home' was frowned upon

    Po> Hmm, any better ideas?

I thought bug 56078 was about the filename not being parsed correctly,
not about the transfer failing?

    >> (and which platform doesnʼt have network-lookup-address-info?)

    Po> MS-DOS.

Hmm, OK. I wonder what percentage of our test suite actually runs
correctly there.

Robert
-- 

Re: master 1d681a5700: Add test for bug#56078 fix

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 21 Jun 2022 12:23:41 +0200
> 
>     Po> MS-DOS.
> 
> Hmm, OK. I wonder what percentage of our test suite actually runs
> correctly there.

I don't know, but it should be easy to say skip-unless...