From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#56552: [PATCH] Make gnus display webp images inline Date: Thu, 14 Jul 2022 19:23:18 +0530 Message-ID: <87bktrssvl.fsf@gmail.com> References: <87mtdbswl2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35649"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56552@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 14 15:54:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBzIT-000984-9d for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Jul 2022 15:54:29 +0200 Original-Received: from localhost ([::1]:52812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBzIS-0002UG-8K for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Jul 2022 09:54:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBzI3-0002RV-0G for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 09:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39270) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oBzI2-0002ie-N5 for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 09:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oBzI2-0002EO-Hq for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 09:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jul 2022 13:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56552-submit@debbugs.gnu.org id=B56552.16578068288556 (code B ref 56552); Thu, 14 Jul 2022 13:54:02 +0000 Original-Received: (at 56552) by debbugs.gnu.org; 14 Jul 2022 13:53:48 +0000 Original-Received: from localhost ([127.0.0.1]:37029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBzHo-0002Dw-Hs for submit@debbugs.gnu.org; Thu, 14 Jul 2022 09:53:48 -0400 Original-Received: from mail-pg1-f194.google.com ([209.85.215.194]:36352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBzHm-0002Di-U0 for 56552@debbugs.gnu.org; Thu, 14 Jul 2022 09:53:47 -0400 Original-Received: by mail-pg1-f194.google.com with SMTP id s206so1616768pgs.3 for <56552@debbugs.gnu.org>; Thu, 14 Jul 2022 06:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :user-agent:mime-version:content-transfer-encoding; bh=JuBAcYKUlInBJAYxsFGRtl1o56+iNjN5L4hvjWM3+bU=; b=Espcv8U/AenK13i7KZ38xsK46ulh/Xhvk7YNtf7QsBtf4XLJQDGU7mvF5Jgzccwpip mOGtuFZL9EaMxcZ9iIK+Ri3iCyBE2Vpbm62eDIELGHWL/p5N1NRv+W9GO/DuhcZu3CE3 6hNbWLEo6Rzjhe4Mor/LBuIjzlBye00nPKvhFO2SXv/wOWPeg1BN1Wi/S97JurQOI3uu E2EvP5p5aTdXbcnkcqdrozYCs1FpzgY0qwDRHPtj9HN0zXp/t5Vg1N9utA4TFO3vruqd QHiKdor639jzN0VN8oLi/24z0NWJj7tdoMASZ0pscdmvuLHQ+WaPX4KoJDUXu1eQ2DVO 0RqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:user-agent:mime-version:content-transfer-encoding; bh=JuBAcYKUlInBJAYxsFGRtl1o56+iNjN5L4hvjWM3+bU=; b=aJ6tk2DBNvcXRYuqT+cOZ5ueeSHtqp91MqV4Vqfd8aOwvsIxnd6vL0Pw3YAaNH8+vw LVoU7N7oojxSP+seAgMN4Rxblo2NM7j1L8x/j9lGXBiGQYawyLfL/JSL68A/j+1spzC1 mePolL3T1gD90DTJsgKre/aWdW67f2rXOy1JYTIrQK6MbwmkQQKJetogoV8qHVvTQMJQ lm1I7UkS6JT5fXJMCEAbmn94TPLE2JhpzgJ2/D+9tCWu3LIKpTRlShx5UtDeH3A0KL4N MAvjfWPa4zF2IsAHCeWY2jRTWO+pR7P+v+Egz2aMG5vRnLPfG7HiQMBJa1ThZlE2yBmD it4w== X-Gm-Message-State: AJIora9u4e70yN8h4SF9jJDSTu+8YbPWp6CHGZQg6o+utJzkJqtLcgXd /ixgAqNoca4uzCPKIOPimqQ= X-Google-Smtp-Source: AGRyM1uQTBTWYvpBYku0mgzeRqULyDBoNLEKB+5irk5kXhNymxnc0Zj3c2oum7N7IZkAwX27FDYEHA== X-Received: by 2002:a63:b1e:0:b0:3fd:43d9:5354 with SMTP id 30-20020a630b1e000000b003fd43d95354mr7858527pgl.294.1657806818851; Thu, 14 Jul 2022 06:53:38 -0700 (PDT) Original-Received: from localhost ([49.205.81.141]) by smtp.gmail.com with ESMTPSA id f1-20020a170902860100b0016bfa097927sm1455324plo.249.2022.07.14.06.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 06:53:38 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Thu, 14 Jul 2022 06:42:44 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236992 Archived-At: [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=9C= =E0=AF=82=E0=AE=B2=E0=AF=88 14, 2022] Stefan Kangas wrote: > Visuwesh writes: > >> diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el >> index 7256e5a2f7..79217d3400 100644 >> --- a/lisp/gnus/mm-decode.el >> +++ b/lisp/gnus/mm-decode.el >> @@ -193,7 +193,11 @@ mm-inline-media-tests >> `(("image/p?jpeg" >> mm-inline-image >> ,(lambda (handle) >> - (mm-valid-and-fit-image-p 'jpeg handle))) >> + (mm-valid-and-fit-image-p 'jpeg handle))) >> + ("image/webp" >> + mm-inline-image >> + ,(lambda (handle) >> + (mm-valid-and-fit-image-p 'webp handle))) >> ("image/png" >> mm-inline-image >> ,(lambda (handle) > > Maybe this comment belongs in a separate wishlist item, but why isn't > this all using the `image-file-name-regexp' function? > > I'm looking at `org-display-inline-images', and it seems to me that > org-mode didn't need any additional changes at all to get support for > inline webp images once Emacs had it? So would it be better if Gnus did > things more like org-mode? I will leave this to a Gnus expert to answer. I arrived at that answer after edebugging around in the relevant Gnus functions. >> diff --git a/lisp/net/mailcap.el b/lisp/net/mailcap.el > > This part LGTM. Thanks.