From: Ihor Radchenko <yantar92@gmail.com>
To: Gregory Heytings <gregory@heytings.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, Eli Zaretskii <eliz@gnu.org>,
57804@debbugs.gnu.org, Paul Pogonyshev <pogonyshev@gmail.com>
Subject: bug#57804: An infinite loop in a `fontify-region' function causes Emacs to hang indefinitely
Date: Fri, 16 Sep 2022 09:17:00 +0800 [thread overview]
Message-ID: <87bkrgunhv.fsf@localhost> (raw)
In-Reply-To: <b24128855b1f7224b117@heytings.org>
Gregory Heytings <gregory@heytings.org> writes:
>> Depending on the mode being activated before Emacs decides to enable the
>> optimization (e.g. because one of the first lines is very long, I don't
>> know how exactly this is determined) seems very shaky.
>
> Indeed. As I told you the proper fix is not to disable these
> optimizations, but to adapt the code to handle locked narrowing, by
> explicitly unlocking the locked narrowing when, and only when, it needs to
> access a larger portion of the buffer.
I would like to point out that some fontification code may use functions
not specifically designed for the fontification. Moreover, the functions
used by fontification may depend on user-defined hooks that can potentially
contain unsuspecting (widen) calls.
While I understand why locked narrowing is needed in buffers with large
files, I would find it helpful if Emacs could throw some kind of warning
when widen is called from inside locked narrowing. It will, at least,
help with adapting the existing fontification code in the new Emacs
versions.
--
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92
next prev parent reply other threads:[~2022-09-16 1:17 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 15:05 bug#57804: An infinite loop in a `fontify-region' function causes Emacs to hang indefinitely Paul Pogonyshev
2022-09-14 16:00 ` dick
2022-09-14 16:06 ` Paul Pogonyshev
2022-09-14 16:14 ` dick
2022-09-14 17:52 ` Lars Ingebrigtsen
2022-09-14 18:18 ` Eli Zaretskii
2022-09-14 16:41 ` Lars Ingebrigtsen
2022-09-14 16:57 ` Paul Pogonyshev
2022-09-14 17:25 ` Lars Ingebrigtsen
2022-09-14 17:30 ` Paul Pogonyshev
2022-09-14 17:43 ` Eli Zaretskii
2022-09-14 17:45 ` Lars Ingebrigtsen
2022-09-14 17:49 ` Eli Zaretskii
2022-09-15 2:17 ` Ihor Radchenko
2022-09-14 17:34 ` Gregory Heytings
2022-09-15 14:47 ` Paul Pogonyshev
2022-09-15 15:10 ` Gregory Heytings
2022-09-15 15:37 ` Paul Pogonyshev
2022-09-15 16:08 ` Gregory Heytings
2022-09-15 16:19 ` Paul Pogonyshev
2022-09-15 16:44 ` Gregory Heytings
2022-09-15 18:49 ` Paul Pogonyshev
2022-09-15 19:16 ` Eli Zaretskii
2022-09-15 19:36 ` Paul Pogonyshev
2022-09-15 19:45 ` Eli Zaretskii
2022-09-15 20:18 ` Gregory Heytings
2022-09-15 20:22 ` Lars Ingebrigtsen
2022-09-15 20:40 ` Paul Pogonyshev
2022-09-15 20:44 ` Gregory Heytings
2022-09-15 21:17 ` Paul Pogonyshev
2022-09-15 21:32 ` Gregory Heytings
2022-09-15 21:49 ` Paul Pogonyshev
2022-09-15 22:16 ` Gregory Heytings
2022-09-15 22:53 ` Paul Pogonyshev
2022-09-15 23:13 ` Gregory Heytings
2022-09-16 6:40 ` Eli Zaretskii
2022-09-16 10:08 ` Paul Pogonyshev
2022-09-16 10:44 ` Eli Zaretskii
2022-09-16 6:31 ` Eli Zaretskii
[not found] ` <1260fd38-d4b3-5ca1-5b15-78f59c0255b6@yandex.ru>
[not found] ` <83o7t9k8fr.fsf@gnu.org>
[not found] ` <CAG7Bpaow570a8Qrq6VxU+=MNF55UmnCMFFXT2Eg=vQUTgrxeoQ@mail.gmail.com>
[not found] ` <34e17bf2a6bdd269fba7@heytings.org>
[not found] ` <CAG7BpapFE0HEwi8iUoStz9EyAwH-QdZ_CxOUNtdUeKDmzCrZaQ@mail.gmail.com>
[not found] ` <338f50d421074805735f@heytings.org>
[not found] ` <831qpnngeg.fsf@gnu.org>
[not found] ` <338f50d421b672315145@heytings.org>
2022-11-28 18:32 ` Eli Zaretskii
2022-09-16 1:17 ` Ihor Radchenko [this message]
2022-09-16 5:35 ` Eli Zaretskii
2022-09-15 19:44 ` Gregory Heytings
2022-09-15 20:07 ` Paul Pogonyshev
2022-09-15 20:26 ` Gregory Heytings
2022-09-16 5:37 ` Eli Zaretskii
2022-09-15 22:20 ` dick
2022-09-15 22:38 ` Gregory Heytings
2022-09-16 6:19 ` Eli Zaretskii
2022-09-16 7:44 ` Gerd Möllmann
2022-09-14 17:02 ` Eli Zaretskii
2022-09-14 17:25 ` Paul Pogonyshev
2022-09-14 17:32 ` Eli Zaretskii
2022-09-14 17:38 ` Lars Ingebrigtsen
2022-09-14 17:44 ` Eli Zaretskii
2022-09-14 17:46 ` Lars Ingebrigtsen
2022-09-14 17:51 ` Eli Zaretskii
2022-09-15 5:20 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-15 6:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkrgunhv.fsf@localhost \
--to=yantar92@gmail.com \
--cc=57804@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
--cc=larsi@gnus.org \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.