From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Stylistic changes to tree-sitter code Date: Sat, 29 Oct 2022 16:34:30 +0800 Message-ID: <87bkpv2fl5.fsf@yahoo.com> References: <87h6zp75nt.fsf.ref@yahoo.com> <87h6zp75nt.fsf@yahoo.com> <87h6zptloj.fsf@gmail.com> <87y1t06apv.fsf@yahoo.com> <87k04ksa4f.fsf@gmail.com> <87k04k5stm.fsf@yahoo.com> <875yg34aas.fsf@yahoo.com> <0E4C5439-B28D-420A-9E4A-BA059269AD57@gmail.com> <87wn8j2nfs.fsf@yahoo.com> <83pmebi05g.fsf@gnu.org> <87sfj72ism.fsf@yahoo.com> <83a65fhwne.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5656"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: casouri@gmail.com, rpluim@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 29 10:35:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oohJW-0001IU-Rh for ged-emacs-devel@m.gmane-mx.org; Sat, 29 Oct 2022 10:35:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oohIr-0000nu-ID; Sat, 29 Oct 2022 04:34:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oohIm-0000nJ-D3 for emacs-devel@gnu.org; Sat, 29 Oct 2022 04:34:49 -0400 Original-Received: from sonic304-20.consmr.mail.ne1.yahoo.com ([66.163.191.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oohIj-0004Dd-4g for emacs-devel@gnu.org; Sat, 29 Oct 2022 04:34:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667032482; bh=k0vACrEF7HEEbmTI7N6aiS6vhb5+oz12xQIp7PYOnHI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=VahdKH2cIHzv17grIu0Yib/l3TGDOilhquqnE1BM7JtQjmz5COOeufr/ANYT4lDaZKcHCdTrxR81q2jYuMKztm/yhwoUT9+OmKb18ovAk0Uj6zTMlvEO7C04wrhv+8OxFGxYaT+LQRTX3vpPI5BVjGtXYqQKRuN2ffdkn0pAlqHtFoo6Pmm3IkqYVVWhiocEiGP9/JIHe23Z8ev/ye42RpD0ff3ImpeJUx6VOZ/M2gIsJXatJ8ExjFY8wzjvgOjUtJFz4v4T9dy6YRl5xNmMZNciWuE8QGkrCSDnYgAwvJWV0Qw7aPxrF4jOmTPveLb/2X7iiG/Wylja1qRYzm6mgw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667032482; bh=iOp30OpwZHEfBqMDASEOcDlm0L5mkK3WOR0Grk8XBD3=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=fHtsSeSIpqdnthC9+DPzkB8Vx1e+PTVpMLgJodc/yizyp7ZVx7Pczj40UyOrNC+j2JZGoGqpLSMt42ihhXFJBy7OkiPvKCtkw9tX1fT5I8SStfncaaq08M6ZRMiKTzT6yB0LCr3V/zXU/bsi6E549u1gfz8C8zhsE/eTc472MGIus/hQ9OmbvhJXwAF4bPL+9TY49HLVXjzeLmkyHYW4JWE7TYrwtYDAvGPiHLbnKkfmnyWDLKb5bSY1l+lkraHt/kQ+/8UhuDKxmcT7d8OjGYsDozf0SPvzSCWnSRr4iMPqCgV/gEjaQ78H8DxVfwlDYF3dUnY+neMuH2xkdWW3jQ== X-YMail-OSG: 6q7R6dMVM1k6uiuXFNtEPvpfPbx_UlDLptKp4UaUfvM0RqEnCqr8msnSJklpOtb cJQ62p3GnlkWf5YgZfNt33db_Q4uMqTiryZga_JkITOvC.0wriQaA.4sYraFHlgAc.gQPuypqTbA DVDI1p1mxvm61ot9IuBfFx1cwzukSZnYVdx0QG99IjV3GhnckjpZV8qO9WUoMVrJ9RrdnB8IFS_R NFiDUwVSlGf0Jl4au.9T4iYmGiP24wxBzCqgmml1t1BihM2Ak9L4bbPw4RHKFiLeck8Io5hhFNfD lR3VFPbfM9Y4kwb1y.mfFyxmTVpehKrgckWEiWLkKaXa0UHaRiXYch35apXualZBUgEOuv4jcqvv .G.cppL0z0Iu4bsgrmA3ttZHwL_WORpBG2RfiCDFMTnp.7X0QEu4UZjIoewoNdmSNynDMwadzce8 h0EsoXCemz0Wx5hQWnUt5TZi9nM5RFvmw2MHLSpMdkptAnSIYIK6EdGq9PDTRFkyztFw4xlf0FM0 tgshuIAPs_12bxzQKM9KyXwYaEhRuvVxXNvY2QLM7A1VxbDE14so_KoqySB6aurjNEqSjYZjsdlG HefcHeYulnO4OAV6DeZ.qsajGrelSncMIHadPwHkYH8qlsrPuQ6LXwrTk._0v640PD89W0LIDab8 fY6XyJgfCl9YMFO_feO7mZgwwL0gSnJSzcDmK.MJkPBti6FCWb.xPYEh8Duh.a5jKvIwSlqbYQnU A3t3HpB_f0eYECwqO_50XXP.LCpkoF6K_tchdD7M0C6.1bltlNk6aKn2HziuFFrtjCbNC.FKG9ds PaDXYDPAxgFfalv1yUAaaec8Wu6ao6Wp3PYIuXQrmW X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Sat, 29 Oct 2022 08:34:42 +0000 Original-Received: by hermes--production-sg3-74fb94585-wlrr8 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5173f6e4d4336c6292789217de214111; Sat, 29 Oct 2022 08:34:36 +0000 (UTC) In-Reply-To: <83a65fhwne.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Oct 2022 11:16:53 +0300") X-Mailer: WebService/1.1.20783 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.146; envelope-from=luangruo@yahoo.com; helo=sonic304-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298742 Archived-At: Eli Zaretskii writes: >> From: Po Lu >> Cc: casouri@gmail.com, rpluim@gmail.com, emacs-devel@gnu.org >> Date: Sat, 29 Oct 2022 15:25:13 +0800 >> >> Eli Zaretskii writes: >> >> > That is correct, but your change removed only "we", and left "I" >> > intact. In any case, rephrasing to avoid pronouns doesn't necessarily >> > force us to use passive voice. >> >> Well, if you can, please suggest some better ways to do that. > > Compliance! > >> - - It doesn't expose a syntax tree. We put the syntax tree in the >> - parser object, and updating the tree is handled on the C level. >> + - It doesn't expose a syntax tree. The syntax tree is placed in >> + the parser object, and updating the tree is handled at the C >> + level. > > Here I'd suggest > > It doesn't expose a syntax tree. The syntax tree is part of the > parser object, and updating the tree is handled on the C level. > >> - - We don't expose tree cursor either. I think Lisp is slow enough >> - to nullify any performance advantage of using a cursor, though I >> - don't have evidence. Also I want to minimize the number of new >> - types we introduce. Currently we only add parser and node type. >> + - The tree cursor is not exposed either. I think Lisp is slow >> + enough to nullify any performance advantage of using a cursor, >> + though I don't have evidence. Also I want to minimize the number >> + of new types we introduce. Currently we only add parser and node >> + type. > > Here I'd suggest > > It doesn't expose the tree cursor, either. Presumably, Lisp is slow > enough to make insignificant any performance advantages from using > the cursor. Not exposing the cursor also minimizes the number of > new types this adds to Emacs Lisp; currently, this adds only the > parser and node types. Thanks, I'll use that text instead.