From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately Date: Fri, 11 Nov 2022 06:32:06 +0000 Message-ID: <87bkpexaqh.fsf@posteo.net> References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39910"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58383@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 11 07:33:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otNbu-000A3b-N8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Nov 2022 07:33:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otNbk-0002NA-0Y; Fri, 11 Nov 2022 01:33:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otNbE-0002ML-Ka for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 01:33:15 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otNb4-0002V9-7t for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 01:33:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otNb3-0005PT-Vo for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 01:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Nov 2022 06:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58383 X-GNU-PR-Package: emacs Original-Received: via spool by 58383-submit@debbugs.gnu.org id=B58383.166814833820728 (code B ref 58383); Fri, 11 Nov 2022 06:33:01 +0000 Original-Received: (at 58383) by debbugs.gnu.org; 11 Nov 2022 06:32:18 +0000 Original-Received: from localhost ([127.0.0.1]:44947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otNaL-0005OF-QZ for submit@debbugs.gnu.org; Fri, 11 Nov 2022 01:32:18 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:50259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otNaI-0005O1-WE for 58383@debbugs.gnu.org; Fri, 11 Nov 2022 01:32:16 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A50CF240027 for <58383@debbugs.gnu.org>; Fri, 11 Nov 2022 07:32:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668148328; bh=VpmMOgdjeZl5y1zesRiq2Giz7/B4j7wb6fnKgZqHOos=; h=From:To:Cc:Subject:Date:From; b=OWrkd/FWmbYMa0+T+bY0NCpxHYGGxCimK7hJIf1/2f77A0IKEvS4yujjLHqtk2i0x Zux9CCU3g6OuVs9pYVFKiLIrod+wMQWfaUlSHcBac9AGVM8pVx79vKQ3B1BhkEkX+T 3avMvtpMHgRevn5eu9Lwv8wt83GB5cnFigW8TWtvQOG/o+2+5ZPP+JoANki9nHXjIE 3HuEr3P/5bYt/uGnHlV/fxYAZOocmmw4wTN5OS4EEhGA3JP7mh977WhvwOsuGyILeW N5GIiLcHZNe7PpTx5h2ljF8WkV2sXd4e9wCUTrgVo4rMFibbyOq2KzYCJG5VAZarS4 MQ0V/JEGC+x6w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N7plW6YcVz9rxN; Fri, 11 Nov 2022 07:32:06 +0100 (CET) In-Reply-To: <87pmduwdzs.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 10 Nov 2022 17:07:03 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247570 Archived-At: Sean Whitton writes: >>> Typically you wouldn't want to format patches across a merge, so I would >>> suggest raising an error. >> >> And this is something I don't think can be /expressed/ using vc, because >> while I can collect a number of revisions using `previous-revision', >> there is no general way to verify if a commit is a merge commit. > > Can we do that part on a VCS-by-VCS basis? Default to just calling > previous-revision and hoping for the best, but giving vc-git.el a chance > to raise an error. I guess that would be possible, though it will probably require a new VC method :/ The new `prepare-patch' takes a revision, so it doesn't make sense to pass it a number and have it return multiple patches. Perhaps it will be easier/cleaner to just accept that avoiding merge revisions is the users responsibility. But just to have mentioned it: Do you know that you can mark revisions in log-view and then vc-prepare-patches will use these as the default input when prompting for revisions?