From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#60787: setq-mode-local doesn't work for buffers not visiting files Date: Thu, 19 Jan 2023 14:06:30 -0700 Message-ID: <87bkmudyjt.fsf@melete.silentflame.com> References: <86sfg9bpto.fsf@mail.linkov.net> <87zgafea71.fsf@melete.silentflame.com> <83358711cy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9582"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60787@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 19 22:07:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIc7y-0002KY-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Jan 2023 22:07:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIc7l-0003e0-Sk; Thu, 19 Jan 2023 16:07:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIc7j-0003Xj-K6 for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 16:07:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIc7j-0004qZ-3y for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 16:07:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIc7i-0000Yu-FU for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 16:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jan 2023 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60787 X-GNU-PR-Package: emacs Original-Received: via spool by 60787-submit@debbugs.gnu.org id=B60787.16741624022132 (code B ref 60787); Thu, 19 Jan 2023 21:07:02 +0000 Original-Received: (at 60787) by debbugs.gnu.org; 19 Jan 2023 21:06:42 +0000 Original-Received: from localhost ([127.0.0.1]:44842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIc7O-0000YK-Dv for submit@debbugs.gnu.org; Thu, 19 Jan 2023 16:06:42 -0500 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:42047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIc7L-0000Y5-RS for 60787@debbugs.gnu.org; Thu, 19 Jan 2023 16:06:40 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 78F903200893; Thu, 19 Jan 2023 16:06:33 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 19 Jan 2023 16:06:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1674162393; x=1674248793; bh=Eh vqLRYd5B8odIBZrHxIHcFsWEjeHPSublUMW/GzuIY=; b=FeDlKaiplYVtDuyimT Jz1c6oeZ+/H6AJg2vVJH2OM86xu6JQxWQrdbjQjueHpLqx1tdDFxWa8/gRbEjCws DAGgnIvnW4k6cMJg8OvUpZgMh9rlTereMCKQnxzCSpegX3EwmjW2vk9Srl5P5m9U ITZ83MwTfGOOHuRFfLAnMWyWsAojNPWlmdM1wJmyZt1+YO89T9M/9wyZInwaahuO 20LsdLIFMRwiu/wk6FOsneuBC2bwlicaGdH9QrWJqiLcS08i+Lkhpm90GY6kLXJX 6GBrMXdykaTs/lSvVRDLudaUGQc0Mb2HYA9nKVgxNGo+Xo+GvMvgYZNiWlGSUG29 oZPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674162393; x=1674248793; bh=EhvqLRYd5B8odIBZrHxIHcFsWEje HPSublUMW/GzuIY=; b=kg4ROi2ouneCWlIwCmdNgGRNMJZ3qcIm7JO3+4eBUjzZ rEjoJw5yI01fkxZb4dhdLwpfdcmQHM3nLkR8Lx9m+C9vR9GygmCvBLA5XWjdSiiA Kj+40boABP61EAAaB8SCeCs9JhA9c0A/cIWIP5z7S2FJfgo+01VMJNqd4voA8qH6 ZENqbRKBVDsHuOtnCwqBu02E/p/xTdm5UWlw2T53HnMp6I5lK5GB+Vjaz02xSHP7 nWreLwUQXTNPxRs7pHfCf20mmoUatBoFibHk1CC++RHz5liqe5LCDwuJkTWAJs8x CxmpcKnzH2gJmTVF9mMleNHEms//24Mo1RnY9bee0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddutddgudeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Jan 2023 16:06:32 -0500 (EST) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 60F307F3931; Thu, 19 Jan 2023 14:06:30 -0700 (MST) In-Reply-To: <83358711cy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Jan 2023 08:31:57 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253731 Archived-At: Hello, On Thu 19 Jan 2023 at 08:31AM +02, Eli Zaretskii wrote: >> Cc: 60787@debbugs.gnu.org >> From: Sean Whitton >> Date: Wed, 18 Jan 2023 15:42:42 -0700 >> >> On Tue 17 Jan 2023 at 09:31AM +02, Juri Linkov wrote: >> >> >> (setq-mode-local diff-mode view-read-only nil) >> >> >> >> doesn't affect *vc-diff* buffers, but it should, according to the docstring of >> >> setq-mode-local. >> > >> > Is this because of the condition `(buffer-file-name b)` >> > in mode-local-map-file-buffers? >> >> Yes, but also how setq-mode-local relies on find-file-hook. > > All of mode-local.el is written under the assumption that only > file-visiting buffers are supported. Evidently, it assumes that modes > for buffers that don't visit files are "not interesting" enough. This > assumption is explicitly in the doc strings of some of its functions. > > I don't know why this was the assumption (maybe because CEDET was > about support of editing program source files?), but if we want to > lift the restriction, it would require changing many of the functions > in the package, not just this one. Maybe we should do that. > mode-local.el wasn't significantly changed since it was added to Emacs > as part of CEDET merge, so maybe it's time to extend it? Sounds good to me. -- Sean Whitton