From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument Date: Thu, 19 Jan 2023 12:05:36 +0100 Message-ID: <87bkmuainz.fsf@gmail.com> References: <878ri2gx3r.fsf@daniel-mendler.de> <87r0vtaxtu.fsf@gmail.com> <3d2cc069-d258-f0b6-9679-eb13a1415202@daniel-mendler.de> <87edrsb5o3.fsf@gmail.com> <9d95e891-22ad-d700-3fab-69948a8a1a17@daniel-mendler.de> <87o7qualwa.fsf@gmail.com> <17aa757a-935d-547c-b432-9529d1ed6d6b@daniel-mendler.de> <87k01iakxz.fsf@gmail.com> <5bbc8220-6745-a123-a143-6b740caec8fa@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7931"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 60867@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 19 12:06:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pISkT-0001r7-IY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Jan 2023 12:06:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pISk8-0000Ly-Vj; Thu, 19 Jan 2023 06:06:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pISk7-0000LZ-Kn for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 06:06:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pISk6-0008OS-TG for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 06:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pISk6-0004Mu-EP for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 06:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jan 2023 11:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60867 X-GNU-PR-Package: emacs Original-Received: via spool by 60867-submit@debbugs.gnu.org id=B60867.167412634616766 (code B ref 60867); Thu, 19 Jan 2023 11:06:02 +0000 Original-Received: (at 60867) by debbugs.gnu.org; 19 Jan 2023 11:05:46 +0000 Original-Received: from localhost ([127.0.0.1]:42764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pISjq-0004MM-Gl for submit@debbugs.gnu.org; Thu, 19 Jan 2023 06:05:46 -0500 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:39703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pISjo-0004M7-PO for 60867@debbugs.gnu.org; Thu, 19 Jan 2023 06:05:45 -0500 Original-Received: by mail-wr1-f46.google.com with SMTP id z5so1478320wrt.6 for <60867@debbugs.gnu.org>; Thu, 19 Jan 2023 03:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=uo/CxRrB2jvvGVppbpK8bN82X4e4n8UPzZMU61bDkzo=; b=cRXLl0ZrfU3NWRTk+QxqBXMCwi/gckPqLjb9wpeei7jm/ckGG0nvugO9AuB2Uwphc0 y1Z+46rKjw07CSuDNyiBXbSJUoriYosXgdGfYYk6yYKJxXakZ5+uuCJu7XgIRKYdvgPl I5N2xWi6ajOu9O7SvKcmB00kRYYgVQnpKUr12hwJtLk2dIpGY0c++WsOj7FBdhQScfiS 7k+aze5dcLM8e0cHULlYhSzBTVoSCT0boRssGlhHaxZjWhiSejGegSOFG0ZIDhssAFOe UEid96fLQiw20Ut7tUyDOo47r2Nt+uYDH8MF4OxF7nk2y0NkA5MmtXnHCQE18+u33nzb VPKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uo/CxRrB2jvvGVppbpK8bN82X4e4n8UPzZMU61bDkzo=; b=wzMzAGlb9X9Pf8SbgT/eas9XpiUxeQJnAEum7rFToqzG3h1+jXmk6b1CbAEvLASVDK x10w80iZattSczkG2FOWODw3wDZBXYKEYZ39wZPLxny7N0Lzleep8YCMrFnbHo8wpMn/ ZRT0IlOIZG9g9+9+R30MeT0+09ErNEgnriVpuiwBnV329jKa76ejd53JXKMX2W6ZnA9Z o7WrGb6dwWU54r7x5tXyodJsBuNbr/tfp7m7PsPvnk0FXbgNjnJkRflB7Gcm8xDvEzYM 1Uf30zWj96OYhK1icvjTt3Gw9twrxjMgW/N143EJQqMD5sXhIO+ShJZEs4u6/n2oQWJD 5u1g== X-Gm-Message-State: AFqh2kqZgFoRnfV6VGAoEhfKHVzb9GoHMHl+OE4WvRSMkljAy9qFxLRl 39F3vgQ5B8MtWxvfDTmYR8c= X-Google-Smtp-Source: AMrXdXuM+eQPAfjUD8muf/JlVN/bgC1tf0TFyQVwItL0ab6htFwUMBrYpFKvVHqudp2qoac2e5SRIA== X-Received: by 2002:a5d:4bce:0:b0:2be:4ae1:215a with SMTP id l14-20020a5d4bce000000b002be4ae1215amr800131wrt.16.1674126338508; Thu, 19 Jan 2023 03:05:38 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id g2-20020a5d64e2000000b002be063f6820sm13877786wri.81.2023.01.19.03.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 03:05:37 -0800 (PST) In-Reply-To: <5bbc8220-6745-a123-a143-6b740caec8fa@daniel-mendler.de> (Daniel Mendler's message of "Thu, 19 Jan 2023 11:39:34 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253698 Archived-At: >>>>> On Thu, 19 Jan 2023 11:39:34 +0100, Daniel Mendler said: Daniel> On 1/19/23 11:16, Robert Pluim wrote: Daniel> Robert, speaking of `key-parse', I wonder why this function acc= epts Daniel> invalid key strings. Why don't we move the `key-valid-p' check = to Daniel> `key-parse'? This would alleviate the need for many additional Daniel> `key-valid-p' checks across keymap.el. One could maybe even get= rid of Daniel> the `keymap--check' helper. >>=20 >> Do you have an example of such an invalid string? Daniel> Just try something like this: Daniel> (key-valid-p "bug") Daniel> (key-parse "bug") Ah, the old "do we have to put spaces between keys" issue. I=CA=BCm not sure how best to deal with that, I=CA=BCll have to read through keymap.el some more. This: (keymap-set k "a" "bug") is already invalid, you have to write either (keymap-set k "a" "b u g") or (keymap-set k "a" (kmacro "b u g")) (I=CA=BCm still tempted to change `kbd' to *always* return a vector, even if all the characters are ASCII) >> I think it=CA=BCs too late to make such changes for emacs-29. I=CA= =BCm not even >> sure that the minimal changes I proposed will be accepted :-) Daniel> I don't think so since of all these functions are new. These se= em like Daniel> simple internal refactorings. Adding a NOERROR argument to key-= parse Daniel> seems like the least intrusive approach. I know emacs-29 hasn=CA=BCt been released yet, but changing a function to error by default when it didn=CA=BCt do previously seems risky. I=CA=BCll m= ake that change locally and see what happens. (Update: it did not go well, there are test-suite failures). Robert --=20