all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62096@debbugs.gnu.org, stephen.berman@gmx.net,
	drew.adams@oracle.com, mardani29@yahoo.es
Subject: bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
Date: Fri, 17 Mar 2023 18:54:51 +0100	[thread overview]
Message-ID: <87bkkrntzo.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <83o7orehnj.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Mar 2023 13:33:52 +0200")

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

[...]

>> Here is the new version.  I also modified the commit message a bit.
>
> LGTM, thanks.

Sorry, here is another version.  WDYT?  Maybe, Drew you could test it to
see if it fixes the bug for you.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-find-ls-option-default-ls-for-BSD-MacOS-bug-6209.patch --]
[-- Type: text/x-patch, Size: 1257 bytes --]

From e1c08afc943358e5afb49478f40722ebbf3cc07f Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Fri, 10 Mar 2023 21:54:00 +0100
Subject: [PATCH] Fix 'find-ls-option-default-ls' for BSD/MacOS (bug#62096)

* lisp/find-dired.el (find-gnu-find-p): New variable to determine
if "find" is a GNU find.
(find-ls-option-default-ls): Use 'find-gnu-find-p' and adapt to a
value that works with the default "find" on *BSD and Darwin/MacOS.
Tested on OpenBSD and MacOS.
---
 lisp/find-dired.el | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/find-dired.el b/lisp/find-dired.el
index 33376ee4ed9..264c6e3082f 100644
--- a/lisp/find-dired.el
+++ b/lisp/find-dired.el
@@ -50,8 +50,13 @@ find-exec-terminator
   :group 'find-dired
   :type 'string)
 
+(defvar find-gnu-find-p
+  (eq 0 (ignore-errors
+          (process-file find-program nil nil nil null-device "--version")))
+  "T if 'find-program' is a GNU find.  NIL otherwise.")
+
 (defvar find-ls-option-default-ls
-  (cons "-ls" (if (eq system-type 'berkeley-unix) "-gilsb" "-dilsb")))
+  (cons "-ls" (if find-gnu-find-p "-dilsb" "-dgils")))
 
 (defvar find-ls-option-default-exec
   (cons (format "-exec ls -ld {} %s" find-exec-terminator) "-ld"))
-- 
2.39.2


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]

-- 
Manuel Giraud

  parent reply	other threads:[~2023-03-17 17:54 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 14:54 bug#62096: 30.0.50; find-dired, dired-goto-file and spaces Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 15:43 ` Drew Adams
2023-03-10 15:59   ` Stephen Berman
2023-03-10 17:10     ` Drew Adams
2023-03-10 18:07     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 18:37       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 20:48         ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:04           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11  0:14             ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 14:02               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 14:17                 ` Eli Zaretskii
2023-03-11 14:27                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17  7:49                     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17  8:33                       ` Eli Zaretskii
2023-03-17  9:12                         ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 11:33                           ` Eli Zaretskii
2023-03-17 15:25                             ` Drew Adams
2023-03-17 15:41                               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 16:14                                 ` Drew Adams
2023-03-17 16:26                               ` Eli Zaretskii
2023-03-17 17:20                                 ` Drew Adams
2023-03-17 17:50                                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 18:56                                     ` Eli Zaretskii
2023-03-17 18:42                                   ` Eli Zaretskii
2023-03-17 17:54                             ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-03-17 18:57                               ` Eli Zaretskii
2023-03-17 19:10                                 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-18  6:34                                   ` Eli Zaretskii
2023-03-18 10:16                                     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-12 10:54                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-12 11:32                     ` Eli Zaretskii
2023-03-12 11:56                       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-12 17:51                     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 17:09                 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 18:46                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 19:30                     ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:31           ` Drew Adams
2023-03-10 21:43             ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 12:00           ` Eli Zaretskii
2023-03-12 10:55           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 11:55         ` Eli Zaretskii
2023-03-11 14:12           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 19:05       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 19:55         ` Drew Adams
2023-03-10 20:42           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:24             ` Drew Adams
2023-03-10 21:32               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:45                 ` Drew Adams
2023-03-10 22:03                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 22:20                     ` Drew Adams
2023-03-11 11:58         ` Eli Zaretskii
2023-03-10 19:48       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkkrntzo.fsf@ledu-giraud.fr \
    --to=bug-gnu-emacs@gnu.org \
    --cc=62096@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=eliz@gnu.org \
    --cc=manuel@ledu-giraud.fr \
    --cc=mardani29@yahoo.es \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.