From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mekeor Melire Newsgroups: gmane.emacs.bugs Subject: bug#62687: [PATCH] Eglot: eglot--sig-info: Show SigInfo Docs if Markup; fix regex for highlighting; etc Date: Sat, 08 Apr 2023 20:44:08 +0000 Message-ID: <87bkjym6ic.fsf@posteo.de> References: <875yaanfuv.fsf@posteo.de> <87fs9bmg1j.fsf@posteo.de> <87cz4egnqa.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36288"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62687@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 08 23:05:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plFkL-0009Fh-EI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Apr 2023 23:05:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plFkC-0001mI-JB; Sat, 08 Apr 2023 17:05:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plFk7-0001m3-3l for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 17:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plFk6-0000Fl-Rd for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 17:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plFk6-0004z1-DZ for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 17:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mekeor Melire Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Apr 2023 21:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62687 X-GNU-PR-Package: emacs Original-Received: via spool by 62687-submit@debbugs.gnu.org id=B62687.168098789819139 (code B ref 62687); Sat, 08 Apr 2023 21:05:02 +0000 Original-Received: (at 62687) by debbugs.gnu.org; 8 Apr 2023 21:04:58 +0000 Original-Received: from localhost ([127.0.0.1]:59721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plFk2-0004yd-06 for submit@debbugs.gnu.org; Sat, 08 Apr 2023 17:04:58 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:55173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plFjz-0004yO-Uw for 62687@debbugs.gnu.org; Sat, 08 Apr 2023 17:04:56 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0BDD7240185 for <62687@debbugs.gnu.org>; Sat, 8 Apr 2023 23:04:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1680987890; bh=WAm2siDUrfkTgkgfiNIJZ6efVR5zYmitnL15wNj8yKQ=; h=From:To:Cc:Subject:Date:From; b=Ifdtjs15IFid2+qJD/IxudP9cHPia6EFC56lLzyK7ChU9P6DruvjvSIp9hu5Ehf0l +7AMvdwRgksFA8zrKvebILpNvMC7wQBnpg1SCgDC1rhTB5IFWH2Z/jsqgHv6B44My0 xCzu9Lz8ZeJ5SVZ/MVyBZscTjw+KRFt+c6DAOIZhJRIQCa08Ul3hkw4EOiAGJmQ8ko 6bgCrGQ9222LQCzQG+EPrgqAo9za2RbwqNmo12SMm+0Cb/sraHeRPli8W3oiyTINjs PCLa1gz5y52qHCXJlxqoLH4YsdukpvNX7GTauN6SWyvsOH/dsARYzvzJYunWjnLMik QC4vf/LEtEbqA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pv7692Wzkz6tvb; Sat, 8 Apr 2023 23:04:49 +0200 (CEST) In-reply-to: <87cz4egnqa.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259496 Archived-At: 2023-04-08 20:47 joaotavora@gmail.com: > Mekeor Melire writes: > > > The main issue is that Eglot won't show the > > "SignatureInformation"'s "documentation" field if it is of > > type MarkupContent. > > OK I see it, I understand it, and I've done some changes to > master. Please have a look at commit > 685435cb52eaa6f61b7088398f1f53e69d76e63e. Thank you! That commit indeed makes Eglot show "SignatureInformation"'s "documentation" field even if it's of type MarkupContent. So it solves this main issue. Unfortunately, that commit causes Eglot to not show the "ParameterInformation"'s "documenation" field. I propose to show both the SigInfo- and the ParamInfo-documentation, whenever possible. (To be more precise: First, the SigInfo-doc should be shown, if non-nil. Then, the ParamInfo-doc should be shown, if non-nil.) What do you think? Would you like to have an audio-call to talk about the problems related to `eglot--sig-info'? I think it would be much more efficient than email.