From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/org 26ef5e3e5b: org-src: Use `sh-mode' for all the shells it can handle Date: Mon, 17 Apr 2023 16:27:46 +0000 Message-ID: <87bkjmh3st.fsf@posteo.net> References: <168174708495.14139.12756054653439048176@vcs2.savannah.gnu.org> <20230417155805.3E200C1391A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34819"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Matthew Trzcinski , emacs-devel To: Lynn Winebarger Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 17 18:27:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poRhc-0008sy-NZ for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Apr 2023 18:27:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1poRhL-0005qe-Up; Mon, 17 Apr 2023 12:27:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poRhJ-0005ph-O0 for emacs-devel@gnu.org; Mon, 17 Apr 2023 12:27:21 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poRhI-00072U-1k for emacs-devel@gnu.org; Mon, 17 Apr 2023 12:27:21 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D222924017E for ; Mon, 17 Apr 2023 18:27:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681748837; bh=86FlznsVWwNItsrAIFR+KW/UarE5lQEUcqbfxb13mYY=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=BSEoRb7A5o6GBCARczSjjweYf5b0IN1fQzAermTv4e+SL0ARcodviR32DXtMzu+Fu tPffRucUJ7inBnAEakfCssnx1LGLZTC8wzBFbAtfwCSP+K0nmqgTC4B3mD0Y3+6jdi v8tGcQN39DaFILD1Q4Lwoz8vMP8R8wUUDUh8WLwnzdfIiPveWLGy+Yol8oynkuEwqZ r+UzQgvURUVlyZRfrsJbof2V82KMMgGrSRebLFTLtU5v4mhSyNyUlyxRPoUyUHSvJT xS4pKU86r3GVJqkocwMttStJMya/fm8v8EKf0+GkQtiPASM57i0fYNy9LUWIxMQlfG veNBaRwQgFScA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q0XWm6yPZz9rxL; Mon, 17 Apr 2023 18:27:16 +0200 (CEST) In-Reply-To: (Lynn Winebarger's message of "Mon, 17 Apr 2023 12:16:36 -0400") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305370 Archived-At: Lynn Winebarger writes: > On Mon, Apr 17, 2023, 12:10 PM Stefan Monnier > wrote: > >> > (defcustom org-src-lang-modes >> > - '(("C" . c) >> > + `(("C" . c) >> > ("C++" . c++) >> > ("asymptote" . asy) >> > - ("bash" . sh) >> > ("beamer" . latex) >> > ("calc" . fundamental) >> > ("cpp" . c++) >> > @@ -208,9 +215,10 @@ but which mess up the display of a snippet in Org >> exported files.") >> > ("elisp" . emacs-lisp) >> > ("ocaml" . tuareg) >> > ("screen" . shell-script) >> > - ("shell" . sh) >> > ("sqlite" . sql) >> > - ("toml" . conf-toml)) >> > + ("toml" . conf-toml) >> > + ("shell" . sh) >> > + ,@(org-src--get-known-shells)) >> > "Alist mapping languages to their major mode. >> >> Side note: while it really doesn't matter here for such trivial >> top-level code, I prefer to put such ,@ at the beginning rather than the >> end of lists, when it's an option. Basically because it's more >> efficient to add to the beginning rather than to the end of a list: >> >> ELISP> (macroexpand '`(,@(list 1 2) a b c d)) >> (append (list 1 2) '(a b c d)) >> ELISP> (macroexpand '`(a b c d ,@(list 1 2))) >> (cons 'a (cons 'b (cons 'c (cons 'd (list 1 2))))) >> ELISP> Is this just an implementation detail, or is there a reason that this could not expand to (append '(a b c d) (list 1 2)) > Why is the former more efficient than the latter? It looks like the former > would have to construct the '(1 2) list twice, and the latter only once. > And the '(a b c d) cons cells are only allocated once either way. (I believe) It is more efficient, since there are fewer function calls. I have had issues in the past with ,@ expanding to code that would have exceeded the maximal evaluation depth, until I split it up and manually used `append' that has the advantage of being implemented in C. > Lynn