From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#60418: [PATCH] Add :vc keyword to use-package Date: Sun, 07 May 2023 07:34:07 +0000 Message-ID: <87bkiwh9xs.fsf@posteo.net> References: <87zgb6uk2r.fsf@hyperspace> <87mt36uwl8.fsf@hyperspace> <83ttxd8k1z.fsf@gnu.org> <87v8hrn56l.fsf@hyperspace> <87cz3w2lvb.fsf@posteo.net> <87jzy3ku6u.fsf@hyperspace> <87bkje93ou.fsf@posteo.net> <87y1mhihhy.fsf@hyperspace> <87ildbet2d.fsf@hyperspace> <831qjyoqj5.fsf@gnu.org> <87h6suolt2.fsf@hyperspace> <83ttwun4q4.fsf@gnu.org> <87o7n0fr9e.fsf@hyperspace> <878re3cqro.fsf@posteo.net> <83ild7jq5c.fsf@gnu.org> <87v8h7ba55.fsf@posteo.net> <83zg6ji806.fsf@gnu.org> <87wn1mlmwx.fsf@posteo.net> <83v8h6hb2q.fsf@gnu.org> <87wn1lguqt.fsf@posteo.net> <837ctlff2x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15431"; mail-complaints-to="usenet@ciao.gmane.io" Cc: soliditsallgood@mailbox.org, felician.nemeth@gmail.com, 60418@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 07 09:35:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvYvL-0003kh-7G for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 May 2023 09:35:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvYvB-0001lK-Ao; Sun, 07 May 2023 03:35:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvYv8-0001lC-VS for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 03:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvYv8-0007XW-M0 for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 03:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvYv8-0001A3-9Y for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 03:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 May 2023 07:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.16834448624400 (code B ref 60418); Sun, 07 May 2023 07:35:02 +0000 Original-Received: (at 60418) by debbugs.gnu.org; 7 May 2023 07:34:22 +0000 Original-Received: from localhost ([127.0.0.1]:36246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvYuU-00018t-1D for submit@debbugs.gnu.org; Sun, 07 May 2023 03:34:22 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:60491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvYuO-00018c-2x for 60418@debbugs.gnu.org; Sun, 07 May 2023 03:34:19 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 021BD240168 for <60418@debbugs.gnu.org>; Sun, 7 May 2023 09:34:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683444850; bh=F8ey6UrUjxX0kxEUEoiP3XKHu1LTgJaU7CciSOQmrcc=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=KkYvuCBi+k4tHLVDxxdaXW4RXBoOtl/nDbOC96JVRH4MdmlwxcfhmRMpYG9SWKRWB V7Kf7ma75bRvWa0x8u185irgiBCksnXCLrt2dCh75f8es+hlmo1ySQUctg1TN8l3EK JRWdk8NEz3sIKx0nuCzw67GAor3fFipgtun/4LfKVU3weW2mbevMJues9rZADoXu+0 MqM7eY5o2KyASPFjWsJZdMPXAsM+/DRc1YW8OI1WVuqO/TH7nSQXh+mi/5vns2kWlw GMUtuNawxOPyNowQ01QZyMJO3LzrQKvwKlfEydPGq8UVW1aSuZhbrIYYiKZ9zlXDn7 foAGgPO9PZ5vQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QDblP11nrz6tw8; Sun, 7 May 2023 09:34:09 +0200 (CEST) In-Reply-To: <837ctlff2x.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 May 2023 22:13:42 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261238 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: soliditsallgood@mailbox.org, 60418@debbugs.gnu.org, >> felician.nemeth@gmail.com, stefankangas@gmail.com >> Date: Sat, 06 May 2023 18:50:02 +0000 >> >> Eli Zaretskii writes: >> >> >> This is true, for package-vc-install, but the idea was not do this for >> >> the :vc keyword to use-package. >> > >> > But I wrote the above as a comment to a patch to package-vc.el, not to >> > use-package. So why use-package is relevant here? >> >> Because this patch is related to use-package, and a keyword that would >> allow for use-package to invoke package-vc-install? > > Yes, but the doc string in package-vc-install should describe > everything that package-vc supports, not just the subset we think will > be useful in use-package via :rev. In that case there was some other unrelated confusion. > Anyway, I think we are in agreement, as your last doc string is > comprehensive enough to make me happy. OK, great! Thank you for your input. -- Philip Kaludercic