From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#64516: [PATCH] docview: Only enable imenu when supported Date: Fri, 28 Jul 2023 12:19:20 +0200 Message-ID: <87bkfwtjtu.fsf@gnu.org> References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> <04eb26ce-b33f-4ebf-9d9d-f1846fead2ed@gnu.org> <87jzuxrppg.fsf@gnu.org> <87edksfimh.fsf@epfl.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13369"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.11.12; emacs 30.0.50 Cc: Morgan Smith , Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 28 12:35:45 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPKoz-0003Bq-Jt for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jul 2023 12:35:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPKeg-0001lk-Rj; Fri, 28 Jul 2023 06:25:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPKec-0001gY-PZ for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 06:25:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPKec-0004Wp-82 for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 06:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qPKeb-00079a-KI for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 06:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2023 10:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64516 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64516-submit@debbugs.gnu.org id=B64516.169053988627442 (code B ref 64516); Fri, 28 Jul 2023 10:25:01 +0000 Original-Received: (at 64516) by debbugs.gnu.org; 28 Jul 2023 10:24:46 +0000 Original-Received: from localhost ([127.0.0.1]:43757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPKeL-00078Y-Jy for submit@debbugs.gnu.org; Fri, 28 Jul 2023 06:24:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPKeG-00078F-Ld for 64516@debbugs.gnu.org; Fri, 28 Jul 2023 06:24:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPKeA-0004Mv-P5; Fri, 28 Jul 2023 06:24:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=KYtoUmJDr+pdXGWnz0yDwAjsiAEXi+GyzZm9la0acnU=; b=EjFHdrvjxwcajU q5mw+JfKxwiPT4VjVyL9uNbeOJcKW5FkKpY2x+b6MwFGynLhiY6zXH0CUwE79r7MMJLdWAaXtWvYy 0syOE0gdUbiEWYCP4LLaTQFABpf6OvifF8QY2hDJQaxU3m+0glgBYZ/cPTiubAxpqihLZg1VkdEnr N3dziEcYrrjxkv5mAYkA6XPFTYX5BcxoYEZk6CJUWOLoBZQTFaEwOgL/U+4ChJj38GV1D7pv0HZ07 Pf0bRJsKmgQLo21qhOzqX7EYQXZ6O0j9dY5YDXdxBWmTm7uJZr7DLrZuf6VW4y0iMn+k6SD5fQ7kX 50gLV8rgCNepy9cUt5cA==; Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPKe8-0001S5-J6; Fri, 28 Jul 2023 06:24:34 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 1363827C0054; Fri, 28 Jul 2023 06:24:32 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 28 Jul 2023 06:24:32 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieeigddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe fgtedtudeivdfhfffhfefhvefhuedvheejjeefleffheekffeutdfhgfejiefhgeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnod hmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedv leekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Jul 2023 06:24:30 -0400 (EDT) In-reply-to: <87edksfimh.fsf@epfl.ch> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266252 Archived-At: "Basil L. Contovounesios" writes: >> diff --git a/lisp/doc-view.el b/lisp/doc-view.el >> index b14655fb274..847601872f5 100644 >> --- a/lisp/doc-view.el >> +++ b/lisp/doc-view.el >> @@ -147,6 +147,8 @@ > [...] >> + (unless (=3D 0 (call-process "mutool" nil (current-buffer) ni= l "show" fn "outline")) >> + (imenu-unavailable-error "Unable to create imenu index usin= g `mutool'")) > > Is call-process guaranteed to return a number? > Would eq/l be more suitable than =3D? Good question, the docs say: If DESTINATION is 0, =E2=80=98call-process=E2=80=99 returns immediately w= ith value nil. Otherwise it waits for PROGRAM to terminate and returns a numeric exit status or a signal description string. I guess if mutool is killed externally while emacs runs it, it could be such a "signal description string" in which case eql would be better even though that situation seems unlikely. I'll change that later. Thanks for the heads-up, Tassilo