From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#65704: 29.1; Most code of `project-ignores' seems to be dead code Date: Wed, 06 Sep 2023 21:12:59 +0200 Message-ID: <87bkefp138.fsf@cassou.me> References: <87sf7wlg07.fsf@cassou.me> <874jkakjt3.fsf@cassou.me> <93d0f377-7acd-ec0d-0e17-f6d09c4dd23a@yandex.ru> <8734zthf5z.fsf@cassou.me> <87tts9qceo.fsf@cassou.me> <5fb6c7df-3f64-5ed2-0c42-a182c6e1a9c4@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18743"; mail-complaints-to="usenet@ciao.gmane.io" To: Dmitry Gutov , 65704@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 06 21:14:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdxyq-0004eI-5i for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Sep 2023 21:14:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdxyX-0005LJ-8B; Wed, 06 Sep 2023 15:14:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdxyT-0005Ky-Cq for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 15:14:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdxyT-0002Ev-4J for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 15:14:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdxyU-000801-2b for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Sep 2023 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65704 X-GNU-PR-Package: emacs Original-Received: via spool by 65704-submit@debbugs.gnu.org id=B65704.169402758930680 (code B ref 65704); Wed, 06 Sep 2023 19:14:02 +0000 Original-Received: (at 65704) by debbugs.gnu.org; 6 Sep 2023 19:13:09 +0000 Original-Received: from localhost ([127.0.0.1]:37744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdxxd-0007ym-DY for submit@debbugs.gnu.org; Wed, 06 Sep 2023 15:13:09 -0400 Original-Received: from mail.choca.pics ([2001:910:1410:500::1]:33080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdxxa-0007yV-4x for 65704@debbugs.gnu.org; Wed, 06 Sep 2023 15:13:07 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id A7A3F18192DDD; Wed, 6 Sep 2023 21:13:01 +0200 (CEST) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavis, port 10032) with ESMTP id Us5aH4NKhKgU; Wed, 6 Sep 2023 21:13:01 +0200 (CEST) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 2275318192DE4; Wed, 6 Sep 2023 21:13:01 +0200 (CEST) X-Virus-Scanned: amavis at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavis, port 10026) with ESMTP id e5KxsTRwp0u7; Wed, 6 Sep 2023 21:13:00 +0200 (CEST) Original-Received: from localhost (91.60.75.86.rev.sfr.net [86.75.60.91]) by mail.choca.pics (Postfix) with ESMTPSA id 6FD6218192DDD; Wed, 6 Sep 2023 21:13:00 +0200 (CEST) In-Reply-To: <5fb6c7df-3f64-5ed2-0c42-a182c6e1a9c4@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269575 Archived-At: Dmitry Gutov writes: > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index 29a81c7e151..2eea0ef72e0 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -566,6 +566,12 @@ project-try-vc > (project--submodule-p root)) > (let* ((parent (file-name-directory (directory-file-name > root)))) > (setq root (vc-call-backend 'Git 'root parent)))) > + (when (not backend) it seems that `root' is sometimes nil at this point so I would change this line to (when (and (not backend) root) I've used this for the day and it seems to work fine. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill