From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manphiz Newsgroups: gmane.emacs.bugs Subject: bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting Date: Sat, 23 Sep 2023 15:34:21 -0700 Message-ID: <87bkds1pua.fsf@debian-hx90.lan> References: <87bke85hsb.fsf@gmail.com> <87a5tobby9.fsf@debian-hx90.lan> <871qf0atqs.fsf@debian-hx90.lan> <878r97ooxs.fsf@posteo.net> <87a5tf3714.fsf@debian-hx90.lan> <87r0mrwkyp.fsf@posteo.net> <875y4331m2.fsf@debian-hx90.lan> <87cyyavcoh.fsf@posteo.net> <87fs3528l2.fsf@debian-hx90.lan> <87fs35vz43.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34193"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65882-done@debbugs.gnu.org, Ryan Yeske , Stefan Kangas , Leo Liu To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 24 00:35:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkBDP-0008iP-UB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Sep 2023 00:35:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkBDA-0000WQ-QN; Sat, 23 Sep 2023 18:34:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkBD9-0000W3-AR for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 18:34:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkBD9-0007V5-1j for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 18:34:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkBDK-0007zn-Bx for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 18:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manphiz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Sep 2023 22:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65882 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65882-done@debbugs.gnu.org id=D65882.169550848330699 (code D ref 65882); Sat, 23 Sep 2023 22:35:02 +0000 Original-Received: (at 65882-done) by debbugs.gnu.org; 23 Sep 2023 22:34:43 +0000 Original-Received: from localhost ([127.0.0.1]:40728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkBD1-0007z5-90 for submit@debbugs.gnu.org; Sat, 23 Sep 2023 18:34:43 -0400 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:42062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkBCz-0007yq-EL for 65882-done@debbugs.gnu.org; Sat, 23 Sep 2023 18:34:42 -0400 Original-Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1c60f1a2652so638505ad.0 for <65882-done@debbugs.gnu.org>; Sat, 23 Sep 2023 15:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695508464; x=1696113264; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=aoSfG21GG4qk8RBVENAqfwIEPxlafPudCf31WPrBWuM=; b=e8tJBoFopOrKIYiXj9wlBsC2MlpHSExC8oL5H4t0tGqWtFCcATZRc2FZv+F9qEX2cg XBAmhzVnry7HgudW//M6vdN/h/LaJb9bYHH4phOUSEUS2IX4mLr0y9wjY7b8PzuGr16I 9JPNOCakXvD1Hq7QICEObSpvFgn3lavnDdS0B0qEwX2dQ25aqBElvtyvql4H6g1qasJU cyJsM5ADoxEmijww+Ps1StrDKXqu2oLrkQNR0skLOQuG2Qb0yPVAr+iIapXFWQSZ/Brz 6Au65lpS3WnuQfAHxSFS10Q1sdeSKvXt+3xV/Sabrv2p6uDfMov17Bvedtty42/ijWFI VfrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695508464; x=1696113264; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aoSfG21GG4qk8RBVENAqfwIEPxlafPudCf31WPrBWuM=; b=GLWBQ51rRe8NC1TMm8Qxb+b1ZQ0mADAwCj2d5CvtiaonRiSpY6ySi461ceeoI5W/2H nVOFvYpN1Z8zZaaRUxn4dQhDezEBf7X5E/vT4dcBJtwGbF2VrHyIMRJPU1Q1Fu4vWYso BrT0Qhm7HsKzZ4MT7AXR4xnjbz46RxFjsHKaKJTSFFqPZ6Bk66rsprCUrRpvTYrKTJlf 69FBdMUr3vLzcmTVROlRn96CB1p0Kuc7sGHRr/FMV4VxMjxO7MBL7pTB84ReieZCLHcH 2LwD8iSRZXIPdwGfqKBBwtOgUoMzm9ZDjsX9qENwLJoHDsyWdDPVmcP5vlWn9aAh72SI qjiA== X-Gm-Message-State: AOJu0YzG4PDZmxHW91dmWEkC80SJw3e/wKRzO2YlQuo8dF4r2zReVezy KOPylsjUfCttQRKskZHtb+I= X-Google-Smtp-Source: AGHT+IHeGIAZSjhQl6nS1JqwmAs2T+S19Jhbu4ZIgAiCkvU6mqmjkaRcBY0ezE8OXsChNz4b5ikdFQ== X-Received: by 2002:a17:902:d2c6:b0:1c5:6f43:9502 with SMTP id n6-20020a170902d2c600b001c56f439502mr5511535plc.14.1695508463612; Sat, 23 Sep 2023 15:34:23 -0700 (PDT) Original-Received: from debian-hx90 (2603-8000-a400-0cdc-9bb5-1305-273c-a54e.res6.spectrum.com. [2603:8000:a400:cdc:9bb5:1305:273c:a54e]) by smtp.gmail.com with ESMTPSA id n11-20020a170902d2cb00b001c06dcd453csm5816200plc.236.2023.09.23.15.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Sep 2023 15:34:22 -0700 (PDT) In-Reply-To: <87fs35vz43.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 23 Sep 2023 12:43:40 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271198 Archived-At: Philip Kaludercic writes: > Stefan Kangas writes: > >> Manphiz writes: >> >>>> I don't necessarily object, but is it a regression? >>> >>> The reconnecting and rejoining channels feature is broken in certain >>> situation, and this patch fixes that. Some other users claimed this >>> works for them, so I would say this may be considered a regression. >>> >>>> Is the change safe? >>> >>> According to the logic of the code, this patch enables doing work that >>> (I believe) should have been done and not changing anything else, so I >>> would say it is safe. >>> >>>> If the answer to either of those questions is "no", I think master is >>>> the safer choice. >>> >>> I would say the answers are both yes, but of course that's just my >>> opinion and the decision is up to you :) >> >> Thanks. If Philip agrees, I see no reason why this can't be installed >> on emacs-29. > > I am fine with it as well, so I'll cherry-pick the branch from master > onto emacs-29. Great! Thanks everyone!