all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jack Kamm <jackkamm@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, kobarity <kobarity@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] python.el: Returning inferior Python output without inhibiting it
Date: Sun, 15 Oct 2023 17:27:45 -0700	[thread overview]
Message-ID: <87bkczif7i.fsf@gmail.com> (raw)
In-Reply-To: <83v8bp6m45.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks.  I will wait for a few days to give others a chance to chime
> in and post comments or suggestions, and will install this after that,
> barring any objections.

Since submitting this patch, I started to have doubts that
`python-shell-send-string-maybe-output' is suitable for ob-python.

So, I suggest not to merge this after all, since ob-python was the main
motivating use case.

The reason is that `python-shell-send-string-no-output' can end
prematurely if the output contains a substring that looks like a prompt,
and ob-python should remain robust to this edge case -- it's not too
far-fetched that some user code executed by ob-python would produce a
substring like ">>>".



      reply	other threads:[~2023-10-16  0:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-01 16:05 [PATCH] python.el: Returning inferior Python output without inhibiting it Jack Kamm
2023-10-01 17:00 ` Eli Zaretskii
2023-10-01 20:23   ` Jack Kamm
2023-10-02  5:54     ` Eli Zaretskii
2023-10-02 12:42       ` kobarity
2023-10-02 16:10         ` Eli Zaretskii
2023-10-16  0:27           ` Jack Kamm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkczif7i.fsf@gmail.com \
    --to=jackkamm@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kobarity@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.