From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Sat, 21 Oct 2023 03:09:55 +0200 Message-ID: <87bkcslr18.fsf@web.de> References: <87il7ib6cu.fsf@posteo.net> <87sf67qqmp.fsf@web.de> <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de> <8734y5vnj7.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15364"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 66394@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 21 03:11:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qu0W7-0003qD-3c for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Oct 2023 03:11:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qu0Vi-0001FT-3L; Fri, 20 Oct 2023 21:10:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu0Vf-0001F2-JP for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 21:10:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qu0Vf-0005gD-0a for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 21:10:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qu0W6-0008Ek-02 for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 21:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 01:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.169785063331619 (code B ref 66394); Sat, 21 Oct 2023 01:11:01 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 21 Oct 2023 01:10:33 +0000 Original-Received: from localhost ([127.0.0.1]:41901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu0VZ-0008Dp-LE for submit@debbugs.gnu.org; Fri, 20 Oct 2023 21:10:33 -0400 Original-Received: from mout.web.de ([217.72.192.78]:42283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu0VU-0008DW-5e for 66394@debbugs.gnu.org; Fri, 20 Oct 2023 21:10:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1697850589; x=1698455389; i=michael_heerdegen@web.de; bh=PrUEpfvbdxC0xz89ysQwOIHkqhUSTixvxVV+fI5Wg3c=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=Kdp/8m4s1SmhYwoYV0ZgTssR0bRaRb1LdZPSOVF6qIM3DEtDWU23a5jRcYCPtdKu LkeyLUNuFz5myqLyHtMrwbpJprFConm4V3iEQAE/hJQnaTUkzcqigTFiTOLPoFuW/ 0zzLoxJyaCnIlyPtNv5KYCl4wDH0iYaOEWdruAVneIwERepH6siH7qJ2WJ+WCan0F UnTsLHXHpcAa34B3hnxb0r3F4qZg72vHr6DmYIwEUp2MvlDENS0ub7uFU3e3zgHUy /TYJ6okUOe7KMrHXeTbkivedU7pD1XjxfLodpew/wWPwS0kDb2SnqDLIFFkJI1a1D sE/K1R2B+du/BG5yEw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.59.210.159]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N14pE-1rdptX1qbi-012Maf; Sat, 21 Oct 2023 03:09:49 +0200 In-Reply-To: <8734y5vnj7.fsf@posteo.net> (Thierry Volpiatto's message of "Fri, 20 Oct 2023 05:49:26 +0000") X-Provags-ID: V03:K1:P98hpJowKAsHL2Ysgckrljm8Imw5TjI2PFDJDDGSs3gRiLSqIt6 qbxdT8JAXOOVkEVUa6jOZmRuaNx92w3bWKadRYtAJyIahCI4NLtY4s575PkVoYhiaYm57Lr 8lCRbiI4riormqNfrrlTObPBXEiADWF9mQUgcTmwbBXDXq21QWOYLw0a44kMp/5Z7/yg8j7 RkQH2gjjFbhbcjNZDQzig== UI-OutboundReport: notjunk:1;M01:P0:kIZ54iX+l4A=;Qk//EcUAtdQICs0awt0a7UGvzRs I4NmdXj6d4+zx9f4hYS+dKcKCU/5PEPBLUWNo+3NAzBIHnG7+XLUJ5H1ddKwjbTZMr/pkj1e/ UaY2h8grxTubbXDcvvYjSqRftFPzwbq3AEF5plAmHKiLbAh10zz+2XxcrSTmZEQExuL0nHoO8 dbOX1WXQB9Hzyxpo+7kLWcTJ+WUr+Z+96xm3IhS8szgwqlNLbB1wcI6iakkFCQ0wxmrMVJIc2 gqgr0UF90YQyp/fs/59W6BEjWDEeZWh5gkwnOQ9W5EnBPnipVJrWsgAkg0AmuiQADbgtoFIw2 K5xZnqLpC45x87gz7EVnVb63imnx1znyanpai7sAjRO/W05Ri7qLS8oInmC3uVZnKTKj4L7D4 AkacwMEu5pRMCWbKuHnywry24730WTHrPoYXV+tHu3EtY6JQTKaUEYZN2oRQQc8xRC9rFYNfn kcYxlNkru4QJQyqXFmbhQjBHgNvDXkvmT3qSOxfFWZlh54HKoYt7+vGKdVXqDhr4H6ufNfFhW 0yHGfHRBak3N5aGwoqewS/K22tf3ukM3AFd8+FBl0wTfOLrDjOOcqOlou3+sA+kC3swMOwEYh VumMwCSK21yTHjlSoVVvox3qq/f2xfv907HHyxves8eXErnaw7B+q9CLsTSOR+V6h4CCsGgbS HAUuOC4adKe95T4Ne88Jao6qXm4Ve/lsSdz4yrrc2/EkwOXzpD0YTF0rCJrOU81yItWZ1R3HK CinR5mrClCzF8fzX4FfwM4TN106igsvNK+H9PXbykYNJS8ovvk6/ybcn8Z7Jd/d7Pdxerowh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272826 Archived-At: Thierry Volpiatto writes: > > For keys like C-a you also need to hit C-q. It's not 100% > > compatible. > > I don't understand, what C-a and C-q have to do here? Also, what C-q > is intended to do in minibuffer? Registers are characters. Control characters are valid registers. So you can for example do C-x r s C-a to save the region string into register `C-a'. Your patch complicates inputting such registers. Dunno if people use such registers, but I wanted to mention this. It's a bit harder now to use non-printable characters as registers now. > > But wait: What I find confusing is that I also need need to confirm for > > `jump-to-register'. Is this intended? > > Do you mean RET? If so yes. For jumping? Why is this useful? > >> Note that now you can use M-n to select in minibuffer the available > >> keys (this only for setting or modifying a register). > > > > In Helm or in vanilla Emacs? I don't see that for M-n in vanilla Emacs. > > Once the patch is applied, C-x r x M-n (repeat if necessary), same for > C-x r w/n etc... Is this part in the patch you had been posting in the first messages? Because I only get "End of history; no default available" with that patch installed. > > Oh, and there is a little bug when the register binding list is empty > > (e.g. after restarting Emacs): your code errors because Emacs does not > > pop up a preview window in that case. > > I think you mean when hitting C-n/p or up/down? > It is fixed in last version of the patch (not publied yet). Let me try to be more precise what I saw: If I start Emacs modified with your patch and do C-x r s with an active region, I see this message in the minibuffer: Error running timer: (error "No buffer named *Register Preview*") Maybe that's already what you have fixed. One more detail: I see "Invalid face reference: helm-match" in the *Messages* of emacs -Q. Still using your first patch (Could you please post the newest version again?). Thanks so far, Michael.