From: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 66863@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#66863: [PATCH] Add two docstrings in cl-macs.el
Date: Tue, 31 Oct 2023 22:36:57 +0000 [thread overview]
Message-ID: <87bkcexvoy.fsf@jeremybryant.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 280 bytes --]
Tags: patch
Hi Emacs maintainers,
Here is a proposed patch with two docstrings added to cl-macs.el where
there were none previously. In particular, from previous changes, I
assume that Stefan you may be familiar with this area? I look forward
to your feedback.
Best
Jeremy
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-two-docstrings-in-cl-macs.el.patch --]
[-- Type: text/patch, Size: 1118 bytes --]
From 9a0d8649511377a160f410fd73f74558f4a8e9dc Mon Sep 17 00:00:00 2001
From: Jeremy Bryant <jb@jeremybryant.net>
Date: Tue, 31 Oct 2023 22:24:20 +0000
Subject: [PATCH] Add two docstrings in cl-macs.el
* lisp/emacs-lisp/cl-macs.el (cl--simple-exprs-p)
(cl--const-expr-p): Add docstrings.
---
lisp/emacs-lisp/cl-macs.el | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
index 43207ce7026..fd19bca60d9 100644
--- a/lisp/emacs-lisp/cl-macs.el
+++ b/lisp/emacs-lisp/cl-macs.el
@@ -101,6 +101,7 @@ cl--simple-expr-p
(and (> size 0) (1- size))))
(defun cl--simple-exprs-p (xs)
+ "Check if no side effects, and executes quickly, for each element of list XS."
(while (and xs (cl--simple-expr-p (car xs)))
(setq xs (cdr xs)))
(not xs))
@@ -118,6 +119,7 @@ cl--safe-expr-p
;;; Check if constant (i.e., no side effects or dependencies).
(defun cl--const-expr-p (x)
+ "Check if X is constant (i.e., no side effects or dependencies)."
(cond ((consp x)
(or (eq (car x) 'quote)
(and (memq (car x) '(function cl-function))
--
2.40.1
next reply other threads:[~2023-10-31 22:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 22:36 Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-10-31 22:58 ` bug#66863: [PATCH] Add two docstrings in cl-macs.el Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-31 23:40 ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01 12:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 9:23 ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 10:41 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkcexvoy.fsf@jeremybryant.net \
--to=bug-gnu-emacs@gnu.org \
--cc=66863@debbugs.gnu.org \
--cc=jb@jeremybryant.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.