From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dape Date: Tue, 05 Dec 2023 08:41:53 +0000 Message-ID: <87bkb5jb1q.fsf@posteo.net> References: <46ea1ab1-e447-4c83-9c81-2f9bd149fe91@alphapapa.net> <6964ff20-921e-beff-43a0-9570ea79aa7d@gutov.dev> <87h6m1yh1x.fsf@posteo.net> <87ttpd2e53.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33025"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , Dmitry Gutov , John Yates , Krister Schuchardt , Adam Porter , emacs-devel@gnu.org To: Daniel Pettersson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 05 09:42:59 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAR18-0008LL-4M for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Dec 2023 09:42:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rAR0I-0006Q2-Ip; Tue, 05 Dec 2023 03:42:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAR0H-0006Pr-KJ for emacs-devel@gnu.org; Tue, 05 Dec 2023 03:42:05 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAR0E-0005yR-0x for emacs-devel@gnu.org; Tue, 05 Dec 2023 03:42:04 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 300FA240103 for ; Tue, 5 Dec 2023 09:41:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1701765716; bh=A+mXeHQnglei1/tpsAd7TBHi+VBB0sUJ75RifTcB9TU=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=caXXGErgEEUw/qczZ8Ris5d32JX8psod9B1Bob8rABmBAjLY1douM8PmtV+0UnqpS S4tVp8V2wCsTDnE85mbwNMQMwZxajaEt8ch5qP14Xg4HAFnvdIWA0Vp2bcL3Z6dFf7 RZso06ZBYZen02w1rFE9tCa8Gv5M7R4e05sxOmmk3XA0W7CgxsN09+BeJ1Zzi6cQrW PJbpyGFHO9hgYnF3CLV8eE2Q9IHHuTBotr/wZ+047iBdZagDHuDkl+VWSp7npF+TQk QPSdlzu7lkzeSnsAn5vC3CZfhHHssw2hWyatL2NdqYCk+OT3HVbEJZCdszaf5K6yCE e+blwKUTg+aRw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SkvCk5740z6txW; Tue, 5 Dec 2023 09:41:54 +0100 (CET) In-Reply-To: <87ttpd2e53.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 23 Nov 2023 07:10:48 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313535 Archived-At: Philip Kaludercic writes: > Philip Kaludercic writes: > >> Daniel Pettersson writes: >> >>> On Wed, Nov 1, 2023 at 7:35=E2=80=AFPM Philip Kaludercic wrote: >>>> Did we ever come to a conclusion on this point? >>> >>> Sorry I have been putting the naming thing off as this thread sparked >>> a bit of interest in the package which lead to a lot of great input and >>> bugfixing. There have been a lot of good suggestions and no consensus >>> which has made the even task harder. >> >> In the end that is your call, it is just currently a blocking issue >> before we add the package to GNU ELPA. > > It seems that the name is here to stay, so I'd go ahead and add the > package to GNU ELPA. It just seems that you forgot to add a copyright > notice to the package header. Could you apply a change along these > lines: > > diff --git a/dape.el b/dape.el > index f5de1cd..949049d 100644 > --- a/dape.el > +++ b/dape.el > @@ -1,5 +1,7 @@ > ;;; dape.el --- Debug Adapter Protocol for Emacs -*- lexical-binding: t = -*- >=20=20 > +;; Copyright (C) 2023 Free Software Foundation, Inc. > + > ;; Author: Daniel Pettersson > ;; Created: 2023 > ;; License: GPL-3.0-or-later > > > Followed by a commit (or in the same one) that bumps the "Version" > header, indicating a new package release? I have resolved the issue directly with Daniel. The package has been added to GNU ELPA. Depending on how it is received, it would be nice to see the package be added to the core in some form or another. By my book, the naming issue could be resolved by adding a `start-dap' command (a `start-lsp' alias for Eglot would also be nice).