From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#67890: 28.2; nnmaildir silently deletes messages upon expiration Date: Thu, 04 Jan 2024 08:32:24 -0800 Message-ID: <87bka1cb53.fsf@ericabrahamsen.net> References: <87edfjgl9o.fsf%stlman@poczta.fm> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20404"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67890@debbugs.gnu.org To: =?UTF-8?Q?=C5=81ukasz?= Stelmach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 04 17:33:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rLQes-00052f-Bw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jan 2024 17:33:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLQeX-0003Rn-E2; Thu, 04 Jan 2024 11:33:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLQeR-0003QI-T8 for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 11:33:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLQeQ-00031q-TW for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 11:32:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rLQeU-0002Mk-AX for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 11:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jan 2024 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67890 X-GNU-PR-Package: emacs Original-Received: via spool by 67890-submit@debbugs.gnu.org id=B67890.17043859639063 (code B ref 67890); Thu, 04 Jan 2024 16:33:02 +0000 Original-Received: (at 67890) by debbugs.gnu.org; 4 Jan 2024 16:32:43 +0000 Original-Received: from localhost ([127.0.0.1]:55507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLQeB-0002M6-2Y for submit@debbugs.gnu.org; Thu, 04 Jan 2024 11:32:43 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:59174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLQe4-0002Lj-ND for 67890@debbugs.gnu.org; Thu, 04 Jan 2024 11:32:40 -0500 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 05110FA0D9; Thu, 4 Jan 2024 16:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1704385946; bh=ocaXAmUrsDX8QJjBFLnixu/rNwaBnyaywq5PwkLV4G4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jmN2DFx2m1YQQxRtCdFM+83k8JLyCwt8B+lc0rFl8/dTuBDBs6lw65HSILIEcyxwB WYviKLeyWbTl+9+Gas1ZcvedDAqHXIt7AIekU2j2c5rdp1oVMR6oESmy2Eiz2nlnDv dHc2d+RFiiSd7lnBGRjOX0TbO59a3J6x9nvEcevI= In-Reply-To: <87edfjgl9o.fsf%stlman@poczta.fm> ("=?UTF-8?Q?=C5=81ukasz?= Stelmach"'s message of "Tue, 19 Dec 2023 00:10:11 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277315 Archived-At: =C5=81ukasz Stelmach writes: > I believe I've found a bug leading to a data loss situation. > > Steps to reproduce. Thanks for the very detailed report! Obviously the `nnmaildir--pgname' problem needs to be fixed, but otherwise it seems like the unlinking step is also a clear bug: we should not be deleting the message if it wasn't successfully expired someplace, right? I'm thinking the end of the `t` clause in the cond there should look like this: (when (and (stringp target) (not (string-equal target pgname))) ;; Move it. (erase-buffer) (nnheader-insert-file-contents nnmaildir--file) (let ((group-art (gnus-request-accept-article target nil nil 'no-encode))) (if group-art (progn (when (consp group-art) ;; Maybe also copy: dormant forward reply save tick ;; (gnus-add-mark? gnus-request-set-mark?) (gnus-group-mark-article-read target (cdr group-art))) ;; Article was successfully moved, delete the original. (nnmaildir--unlink nnmaildir--file) (nnmaildir--expired-article group article)) ;; Leave it here. (setq didnt (cons (nnmaildir--art-num article) didnt))))) It looks to me like `gnus-request-accept-article` can return a (group . article) cons, a symbol, or nil for failure. If we get a nil, we shouldn't remove the original article. Does that seem reasonable? Eric