bug#66944: 30.0.50; [PATCH] make calc parse fractions written using U+2044 FRACTION SLASH

[john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Daniel Brooks <db48x@db48x.net> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> Thanks, I installed the changes on the master branch, and I'm
>> therefore closing this bug.
>
> Awesome. Thanks!
>
> db48x

The calc tests started failing today. Bisect says 77d9d05df87 is
the culprit. Log attached.

  cd ~/src/emacs/test
  make lisp/calc/calc-tests.log


[-- Attachment #2: calc-tests.log --]
[-- Type: text/plain, Size: 4008 bytes --]

Running 25 tests (2024-01-27 12:27:30-0600, selector `(not (or (tag :unstable) (tag :nativecomp)))')
   passed   1/25  calc-Math-integerp (0.000105 sec)
   passed   2/25  calc-bit-ops (0.052791 sec)
Building units table...
Building units table...done
   passed   3/25  calc-bug-23889 (0.012645 sec)
   passed   4/25  calc-business-days (0.002711 sec)
   passed   5/25  calc-calendar (0.000170 sec)
   passed   6/25  calc-choose (0.003441 sec)
   passed   7/25  calc-convert-units (0.006384 sec)
   passed   8/25  calc-defmath (0.000104 sec)
   passed   9/25  calc-digit-after-point (0.000116 sec)
   passed  10/25  calc-extract-units (0.000571 sec)
   passed  11/25  calc-format-radix (0.000098 sec)
   passed  12/25  calc-frac-input (0.000218 sec)
   passed  13/25  calc-gcd (0.000080 sec)
   passed  14/25  calc-imaginary-i (0.001161 sec)
   passed  15/25  calc-latex-input (0.002340 sec)
Test calc-math-read-preprocess-string backtrace:
  signal(ert-test-failed (((should (string= (concat "+/-*:-/*inf<=>=<=
  ert-fail(((should (string= (concat "+/-*:-/*inf<=>=<=>=μ(1:4)(1:2)(3
  (if (unwind-protect (setq value-1055 (apply fn-1053 args-1054)) (set
  (let (form-description-1057) (if (unwind-protect (setq value-1055 (a
  (let ((value-1055 'ert-form-evaluation-aborted-1056)) (let (form-des
  (let* ((fn-1053 #'string=) (args-1054 (condition-case err (list (con
  (closure (var-g t) nil (let* ((fn-1023 #'string=) (args-1024 (condit
  #f(compiled-function () #<bytecode -0x666deb319dd90b0>)()
  handler-bind-1(#f(compiled-function () #<bytecode -0x666deb319dd90b0
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name calc-math-read-preprocess-string :doc
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
  ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
  ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
  eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/calc/calc-tests.el" 
  command-line()
  normal-top-level()
Test calc-math-read-preprocess-string condition:
    (ert-test-failed
     ((should
       (string=
	(concat "+/-*:-/*inf<=>=<=>=μ(1:4)(1:2)(3:4)(1:3)(2:3)"
		"(1:5)(2:5)(3:5)(4:5)(1:6)(5:6)"
		"(1:8)(3:8)(5:8)(7:8)1:^(0123456789+-()ni)"
		"_(0123456789+-())")
	(math-read-preprocess-string ...)))
      :form
      (string=
       "+/-*:-/*inf<=>=<=>=μ(1:4)(1:2)(3:4)(1:3)(2:3)(1:5)(2:5)(3:5)(4:5)(1:6)(5:6)(1:8)(3:8)(5:8)(7:8)1:^(0123456789+-()ni)_(0123456789+-())"
       "+/-*:-/*inf<=>=<=>=μ(1:4)(1:2)(3:4)(1:3)(2:3)(1:5)(2:5)(3:5)(4:5)(1:6)(5:6)(1:8)(3:8)(5:8)(7:8)1::^(0123456789+-()ni)_(0123456789+-())")
      :value nil :explanation
      (arrays-of-different-length 133 134
				  "+/-*:-/*inf<=>=<=>=μ(1:4)(1:2)(3:4)(1:3)(2:3)(1:5)(2:5)(3:5)(4:5)(1:6)(5:6)(1:8)(3:8)(5:8)(7:8)1:^(0123456789+-()ni)_(0123456789+-())"
				  "+/-*:-/*inf<=>=<=>=μ(1:4)(1:2)(3:4)(1:3)(2:3)(1:5)(2:5)(3:5)(4:5)(1:6)(5:6)(1:8)(3:8)(5:8)(7:8)1::^(0123456789+-()ni)_(0123456789+-())"
				  first-mismatch-at 97)))
   FAILED  16/25  calc-math-read-preprocess-string (0.000212 sec) at lisp/calc/calc-tests.el:846
   passed  17/25  calc-matrix-determinant (0.003859 sec)
   passed  18/25  calc-nth-root (0.000213 sec)
Working...
(Remainder was 8 * x + 1)
   passed  19/25  calc-poly-div (0.002111 sec)
Working...

   passed  20/25  calc-remove-units (0.000210 sec)
   passed  21/25  calc-shift-binary (0.032695 sec)
   passed  22/25  calc-solve-linear-system (0.004019 sec)
   passed  23/25  calc-sum-gcd (0.000234 sec)
   passed  24/25  calc-trig (0.000546 sec)
   passed  25/25  calc-unix-date (0.000296 sec)

Ran 25 tests, 24 results as expected, 1 unexpected (2024-01-27 12:27:30-0600, 0.255913 sec)

1 unexpected results:
   FAILED  calc-math-read-preprocess-string