From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Eglot cannot work with default completion-in-region? Date: Sun, 28 Jan 2024 11:23:33 +0100 Message-ID: <87bk9592oq.fsf@daniel-mendler.de> References: <87ttmy7pog.fsf@catern.com> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10652"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Dmitry Gutov To: sbaugh@catern.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 28 11:24:58 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rU2LS-0002WZ-S7 for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Jan 2024 11:24:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rU2KZ-0002Ws-Io; Sun, 28 Jan 2024 05:24:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rU2KX-0002Wf-Et for emacs-devel@gnu.org; Sun, 28 Jan 2024 05:24:01 -0500 Original-Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rU2KV-0001Xg-4l for emacs-devel@gnu.org; Sun, 28 Jan 2024 05:24:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=X1vdPhmUHxmBnPHwQJGEJwnl/c+eIkmPRyVIE6bZAHE=; b=cUgkPeO4+lq661zAOJQ56W2qda bsGje7moJ3ZTzKEbxyeEcZJj40uQMK/q9Z5F+aBHJ2fVKgluezu+xCSJixHhWCtF1cAKsCHIa6yLL heRC20IP3trBXF3sAjluqb2O31dqs7C53mBRuvFC9bXvNzkr8GswLJP2RhhwE4h45Y2Y=; In-Reply-To: <87ttmy7pog.fsf@catern.com> (sbaugh@catern.com's message of "Sat, 27 Jan 2024 15:37:35 +0000") Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315539 Archived-At: sbaugh@catern.com writes: [96 lines...] > I would also find this useful elsewhere too - the fact that > exit-function strips the properties is quite annoying, and the ability > to transform the completion (possibly preserving text properties when > inserted) would be handy. FWIW both Company and Corfu preserve text properties when calling the exit function as long as the completion candidate is unique or was selected explicitly in the popup menu. Duplicate candidates (with respect to equal) are kept in the Corfu/Company popup menus. Duplicates are also kept in the Completions buffer as long as their prefix or suffix annotations are distinct, but unfortunately the distinction is lost, text properties are stripped, as soon as a candidate is selected. Daniel