From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#69555: 30.0.50; shr - Preserve indentation when shr-fill-text is nil Date: Wed, 06 Mar 2024 22:18:19 +0100 Message-ID: <87bk7rt5yc.fsf@gmail.com> References: <87o7btzmdo.fsf@gmail.com> <87jzmhzm3v.fsf@gmail.com> <861q8onan6.fsf@gnu.org> <877cigzdo3.fsf@gmail.com> <86edcolav6.fsf@gnu.org> <87jzmgi80q.fsf@gmail.com> <868r2vlgp9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32114"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69555@debbugs.gnu.org, rahguzar@zohomail.eu To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 06 22:19:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhyg3-00082Z-D0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Mar 2024 22:19:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhyfo-00035w-9H; Wed, 06 Mar 2024 16:19:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhyfk-000356-T2 for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2024 16:19:33 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhyfj-0000ug-8t for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2024 16:19:32 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rhygD-00058E-SY for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2024 16:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Mar 2024 21:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69555 X-GNU-PR-Package: emacs Original-Received: via spool by 69555-submit@debbugs.gnu.org id=B69555.170976000019715 (code B ref 69555); Wed, 06 Mar 2024 21:20:01 +0000 Original-Received: (at 69555) by debbugs.gnu.org; 6 Mar 2024 21:20:00 +0000 Original-Received: from localhost ([127.0.0.1]:51765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhygC-00057v-0B for submit@debbugs.gnu.org; Wed, 06 Mar 2024 16:20:00 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:42043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhyg9-00057f-Pr for 69555@debbugs.gnu.org; Wed, 06 Mar 2024 16:19:58 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-412ea23a750so1490845e9.0 for <69555@debbugs.gnu.org>; Wed, 06 Mar 2024 13:19:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709759901; x=1710364701; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2bltDiMhdt7crl2nfExp5EApHdQKG9IWQ3xEODzDxUY=; b=Sb0sO1rnPjiDYEVAHRcgbyB493joJJIoKKdPsfqeWc6mHbTobVudaCVFaW/oBjPBDM 3uA9ptKVBTpClGpCusRIbcwLOCnvokcyCbw9crytvOtBodm2b9YdHguJTT+z8JMIW80V fTt6FF8VU3T7FJxfPWCzMoPDnPFC2lMaW0hI2f7k/puilOi6nDh7xDc0nbu8Vrh0287Z qlWmCwv9LbHG8QPakfQupR7hYjjYNKoQXmMQkdp822qfxqpcAJQIlINUqN3lFS6FGOh4 sFUw7xze8sD8qfvsgVjW+tp3HBOtzoqUfFAlvZU/utIbKSNCnzU2d7MNhci9WSpjcqnD DvDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709759901; x=1710364701; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2bltDiMhdt7crl2nfExp5EApHdQKG9IWQ3xEODzDxUY=; b=sC7apwRAfDWyI/31MUT9nzbMuVdDJsrwbvygrZlN3KI2TL02zl4+32pvYXxg9TYOUg LiCLUAbzoPEbeSzC6qofXTparcN35h4H+fHjJbmAGQMWhwQizcTl6+naxwgBvMqA8Ov6 xnaPhMeiRYgnQ2Dcb+28J1+B+eGttZNVttZIhuZGzgC8Xuz3KQqqqiY8ZVq24mvfjK9g utsIGb4ej9fyR8FpeTeO8ajbiFjz5vzTuC1z/0wAw/PlzKFsabloKimQnkDu+BBw62f9 zah0eNOEIrC2wkQCCClvLARSAWsLe38PSvT26TTDjh0yypuBjKChfxIhPfZ3BY8wN1b9 ZNGg== X-Gm-Message-State: AOJu0Yzi74ImlBW+ClZqMb5neAzk+bVDzfaQCfNEJi1nzbwe31fisIj5 pVI/RIZtMUbv7Sn+bNb5Jw49OQ9g/mwIOchAyJ1XAXD+3zvVyisb X-Google-Smtp-Source: AGHT+IHaRvjt7Um9OJTJlbU1ctyE33RzvlnqOd2x6o7QH0z/u7Vs8S8ulQ40mV73jS6TUC2V/1jLZQ== X-Received: by 2002:a05:600c:3b0a:b0:412:c379:606 with SMTP id m10-20020a05600c3b0a00b00412c3790606mr6229125wms.2.1709759900679; Wed, 06 Mar 2024 13:18:20 -0800 (PST) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id f14-20020a5d50ce000000b0033b66c2d61esm18458841wrt.48.2024.03.06.13.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 13:18:20 -0800 (PST) In-Reply-To: <868r2vlgp9.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Mar 2024 13:53:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281129 Archived-At: Eli Zaretskii writes: >> From: K=C3=A9vin Le Gouguec >> Cc: 69555@debbugs.gnu.org, rahguzar@zohomail.eu >> Date: Wed, 06 Mar 2024 00:16:53 +0100 >>=20 >> If not, the tentative conclusion would be "shr-fill-text nil gets 4% >> slower; shr-fill-text t is none the worse for wear; nil still runs >> circles around t"? > > Thanks, I think 4% slowdown is negligible in this case. ACK. Re. indentation being done unconditionally=E2=80=A6 K=C3=A9vin Le Gouguec writes: > Eli Zaretskii writes: > >> The change in behavior is unconditional, AFAIU. Should we have a >> separate knob for that? Perhaps someone out there doesn't want text >> to be indented when shr-fill-text is nil? > > Perhaps; I could look into adding that knob. FWIW nothing in the > original feature request (bug#66676) gives me the impression that this > new option should affect indentation; the stated motivation was: > > > 1) Using `visual-line-mode` for line wrapping. I think this is more > > natural for html and makes resizing windows work more nicely. > > That's why I interpret the indentation change as a side-effect; curious > to hear Rahguzar's thoughts though. =E2=80=A6 considering Rahguzar's reply (thanks for that, and for the offer = to try the patch =F0=9F=99=8F)=E2=80=A6 > Another reason I'm not overly fond of adding another knob is figuring > out what should happen if a user keeps shr-fill-text set to t, but sets > that hypothetical indentation option to nil. Should we support that? > Or should shr-fill-text become a tri-state? (nil, 'indent-only, t) > > I'm open to biting the bullet, but I'd also like to make sure we don't > sophisticate shr.el further than we want to. =E2=80=A6 do we think there is a case for an option to disable indentation = then? Or should we leave that for a future feature request?