* [PATCH] Silence a warning in org-table.el
@ 2024-05-05 16:56 Bastien
2024-05-05 17:38 ` Ihor Radchenko
0 siblings, 1 reply; 3+ messages in thread
From: Bastien @ 2024-05-05 16:56 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 125 bytes --]
The attached patch silences a warning.
This seems trivial, if nobody bites I'll apply this tomorrow.
Thanks!
--
Bastien
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-table.el.patch --]
[-- Type: text/x-diff, Size: 547 bytes --]
diff --git a/lisp/org-table.el b/lisp/org-table.el
index 0c2dc27ed..3d40a02a1 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -2887,7 +2887,7 @@ list, `literal' is for the format specifier L."
(if lispp
(if (eq lispp 'literal)
elements
- (if (and (eq elements "") (not keep-empty))
+ (if (and (string= elements "") (not keep-empty))
;; FIXME: This branch of `if' is never used because
;; strings are never `eq' here. But changing to
;; `equal' breaks tests.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Silence a warning in org-table.el
2024-05-05 16:56 [PATCH] Silence a warning in org-table.el Bastien
@ 2024-05-05 17:38 ` Ihor Radchenko
2024-05-06 8:11 ` Bastien Guerry
0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2024-05-05 17:38 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
Bastien <bzg@gnu.org> writes:
> This seems trivial, if nobody bites I'll apply this tomorrow.
It just _seems_ trivial. This innocently-looking patch will break tests.
Duplicate of https://list.orgmode.org/orgmode/875y2oxfd8.fsf@red-bean.com/T/#u
Canceled.
And yes, it is annoying. Just not very clear how to address correctly.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Silence a warning in org-table.el
2024-05-05 17:38 ` Ihor Radchenko
@ 2024-05-06 8:11 ` Bastien Guerry
0 siblings, 0 replies; 3+ messages in thread
From: Bastien Guerry @ 2024-05-06 8:11 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
Ihor Radchenko <yantar92@posteo.net> writes:
> It just _seems_ trivial. This innocently-looking patch will break tests.
>
> Duplicate of https://list.orgmode.org/orgmode/875y2oxfd8.fsf@red-bean.com/T/#u
> Canceled.
Doh! And I already reverted this myself! I'm getting old.
Thanks.
--
Bastien Guerry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-06 8:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-05 16:56 [PATCH] Silence a warning in org-table.el Bastien
2024-05-05 17:38 ` Ihor Radchenko
2024-05-06 8:11 ` Bastien Guerry
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.