[PATCH] Remove warning about org-clock-save.el lacking lexical-binding directive

[PATCH] Remove warning about org-clock-save.el lacking lexical-binding directive

[Bastien]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

Recent versions of Emacs complain about org-clock-save.el:

  ⛔ Warning (lexical-binding): File
  /home/bzg/.emacs.d/org-clock-save.el lacks `lexical-binding'
  directive on its first line

The attached patch should fix this.  Is it okay to add it to bugfix?

Thanks,

-- 
 Bastien

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-clock.el.patch --]
[-- Type: text/x-diff, Size: 596 bytes --]

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 67feb6b35..806bc02de 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -3233,7 +3233,7 @@ The details of what will be saved are regulated by the variable
 		 org-clock-has-been-used
 		 (not (file-exists-p org-clock-persist-file))))
     (with-temp-file org-clock-persist-file
-      (insert (format ";; %s - %s at %s\n"
+      (insert (format ";; %s - %s at %s -*- lexical-binding: t; -*-\n"
 		      (file-name-nondirectory org-clock-persist-file)
 		      (system-name)
 		      (format-time-string (org-time-stamp-format t))))

Re: [PATCH] Remove warning about org-clock-save.el lacking lexical-binding directive

[Ihor Radchenko]

Bastien <bzg@gnu.org> writes:

> Recent versions of Emacs complain about org-clock-save.el:
>
>   ⛔ Warning (lexical-binding): File
>   /home/bzg/.emacs.d/org-clock-save.el lacks `lexical-binding'
>   directive on its first line
>
> The attached patch should fix this.  Is it okay to add it to bugfix?

I think that it is premature.
This is a warning recently introduced on Emacs master, and it is still
being debated upon. See
https://yhetil.org/emacs-devel/50E29988-D354-4D10-990F-31828DBE6411@gmail.com/t/#u

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [PATCH] Remove warning about org-clock-save.el lacking lexical-binding directive

[Bastien Guerry]

Ihor Radchenko <yantar92@posteo.net> writes:

> I think that it is premature.
> This is a warning recently introduced on Emacs master, and it is still
> being debated upon. See
> https://yhetil.org/emacs-devel/50E29988-D354-4D10-990F-31828DBE6411@gmail.com/t/#u

Okay, fair enough.

-- 
 Bastien Guerry

Re: [PATCH] Remove warning about org-clock-save.el lacking lexical-binding directive

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:

>>   ⛔ Warning (lexical-binding): File
>>   /home/bzg/.emacs.d/org-clock-save.el lacks `lexical-binding'
>>   directive on its first line
>>
>> The attached patch should fix this.  Is it okay to add it to bugfix?
>
> I think that it is premature.
> This is a warning recently introduced on Emacs master, and it is still
> being debated upon. See
> https://yhetil.org/emacs-devel/50E29988-D354-4D10-990F-31828DBE6411@gmail.com/t/#u

And they reverted the warning at the end.
https://git.savannah.gnu.org/cgit/emacs.git/commit?id=d51de0c5d90117bc1dc4bc5bc700253d71cd4579

Canceled.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [PATCH] Remove warning about org-clock-save.el lacking lexical-binding directive

[Bastien Guerry]

Ihor Radchenko <yantar92@posteo.net> writes:

> And they reverted the warning at the end.
> https://git.savannah.gnu.org/cgit/emacs.git/commit?id=d51de0c5d90117bc1dc4bc5bc700253d71cd4579

Yes, it makes sense.

-- 
 Bastien Guerry