Re: master 8074c08cd55: Use proper smime-keys entry for S/MIME signatures using OpenSSL

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Tue, 14 May 2024 10:45:08 -0400 (EDT), Eric Abrahamsen <eric@ericabrahamsen.net> said:

    Eric> branch: master
    Eric> commit 8074c08cd553ab6ee5ffe61cc2e56fb1e0a4fe34
    Eric> Author: Illia Ostapyshyn <illia@yshyn.com>
    Eric> Commit: Eric Abrahamsen <eric@ericabrahamsen.net>
 
    Eric> -(defun mml-smime-openssl-sign (_cont)
    Eric> -  (when (null smime-keys)
    Eric> -    (customize-variable 'smime-keys)
    Eric> -    (error "No S/MIME keys configured, use customize to add your key"))
    Eric> -  (smime-sign-buffer (cdar smime-keys))
    Eric> +(defun mml-smime-openssl-sign (cont)
    Eric> +  (smime-sign-buffer
    Eric> +   ;; List with key and certificate as its car, and a list of additional
    Eric> +   ;; certificates to include in its cadr for smime-sign-region
    Eric> +   (list
    Eric> +    (cdr (assq 'keyfile cont))
    Eric> +    (mapcar #'cdr (cl-remove-if-not (apply-partially #'equal 'chainfile)
    Eric> +                                    cont
    Eric> +                                    :key #'car-safe))))

Minor grumble:

  ELC      gnus/mml-smime.elc

In end of data:
gnus/mml-smime.el:138:20: Warning: the function ‘cl-remove-if-not’ might not be defined at runtime.

In reality 'cl-lib' will almost certainly already be loaded by anyone
using gnus, but any warning that can be avoided should be.

Robert
--