From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 73c1252bb6b: Fix link to major mode variable in docstring Date: Mon, 08 Jul 2024 15:58:19 +0000 Message-ID: <87bk37x4dg.fsf@posteo.net> References: <171956993509.30805.5525504753117432129@vcs2.savannah.gnu.org> <20240628101855.7E69DC2BC60@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38223"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eshel Yaron , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 08 17:56:43 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQqjK-0009j6-FD for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Jul 2024 17:56:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQqiF-0001Fr-5e; Mon, 08 Jul 2024 11:55:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQqiD-0001FW-SL for emacs-devel@gnu.org; Mon, 08 Jul 2024 11:55:33 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQqiC-0005N2-9O for emacs-devel@gnu.org; Mon, 08 Jul 2024 11:55:33 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1D8CC240101 for ; Mon, 8 Jul 2024 17:55:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1720454116; bh=71xUFSpjR2EARPIGIkw2H1gxWNw1Ab4YqIBNcuNCBjM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:Autocrypt:OpenPGP:From; b=ZzhR04VAaKTDXWJTm/ODMnMuK6Wqo6A8i6yMiY8lDlo5bPgcs5/Ysv26awHZgIl3M mhtd08XYm1+E7hLTqpANHzdkw+xH0exwDCE5D4tILxbtK6ZlQoZvA4FuCkJBE9M7S+ hYfP9JtmTe+ANBjLDImqbMEipepAY+6ZmVrpopmjAT6xcyJNDW0yi1ydeN8EDffkxA AaVKfljRSTFNL9ALViH0ODdp+eWwDltiFzLonzoHRWesQHbrOp8utDllhSQQ1KfmUZ mulRBQ0df2o6731AZhNBzIZCBagYlzvW5lp0Uoqqj5c+dhthLLTjEviXTU6MvywUuL XqyKnnNd2QNnw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WHpc31ygbz9rxL; Mon, 8 Jul 2024 17:55:15 +0200 (CEST) In-Reply-To: (Stefan Kangas's message of "Mon, 8 Jul 2024 11:48:56 +0000") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=thievol@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321542 Archived-At: Stefan Kangas writes: > Eshel Yaron writes: > >> I think it's not always correct to say "the variable" here, because that >> "%s" may be replaced with a form that's not just a variable. E.g. now >> C-h f global-auto-revert-mode RET says: >> >> To check whether the minor mode is enabled in the current buffer, >> evaluate the variable =E2=80=98(default-value 'global-auto-revert-mode= )=E2=80=99. > > Thanks, you're right. Now reverted. No, this is not right, reverting fix nothing, we are just back to previous bug, this is unrelated, the bug is in `easy-mmode--mode-docstring` which have a misleading arg called 'getter' and naturally `define-minor-mode` pass 'getter' to it instead of passing 'mode'. PS: Please CC me as I am not suscribed to this list, thanks. --=20 Thierry