all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thierry Volpiatto <thievol@posteo.net>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Eshel Yaron <me@eshelyaron.com>,  emacs-devel@gnu.org
Subject: Re: emacs-30 73c1252bb6b: Fix link to major mode variable in docstring
Date: Mon, 08 Jul 2024 15:58:19 +0000	[thread overview]
Message-ID: <87bk37x4dg.fsf@posteo.net> (raw)
In-Reply-To: <CADwFkmkvh2SnAwmHqtVvxeaBVyWeOnM0WJBJqneCT4gaJ7i+Eg@mail.gmail.com> (Stefan Kangas's message of "Mon, 8 Jul 2024 11:48:56 +0000")

Stefan Kangas <stefankangas@gmail.com> writes:

> Eshel Yaron <me@eshelyaron.com> writes:
>
>> I think it's not always correct to say "the variable" here, because that
>> "%s" may be replaced with a form that's not just a variable.  E.g. now
>> C-h f global-auto-revert-mode RET says:
>>
>>   To check whether the minor mode is enabled in the current buffer,
>>   evaluate the variable ‘(default-value 'global-auto-revert-mode)’.
>
> Thanks, you're right.  Now reverted.

No, this is not right, reverting fix nothing, we are just back to previous
bug, this is unrelated, the bug is in `easy-mmode--mode-docstring` which
have a misleading arg called 'getter' and naturally `define-minor-mode`
pass 'getter' to it instead of passing 'mode'.

PS: Please CC me as I am not suscribed to this list, thanks.

-- 
Thierry



  reply	other threads:[~2024-07-08 15:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171956993509.30805.5525504753117432129@vcs2.savannah.gnu.org>
     [not found] ` <20240628101855.7E69DC2BC60@vcs2.savannah.gnu.org>
2024-07-08  9:34   ` emacs-30 73c1252bb6b: Fix link to major mode variable in docstring Eshel Yaron
2024-07-08 11:48     ` Stefan Kangas
2024-07-08 15:58       ` Thierry Volpiatto [this message]
2024-07-08 23:26         ` Michael Heerdegen via Emacs development discussions.
2024-07-09  0:37           ` Michael Heerdegen via Emacs development discussions.
2024-07-09  4:22         ` Thierry Volpiatto
2024-07-09  5:01           ` Michael Heerdegen via Emacs development discussions.
     [not found]             ` <87y16b3zhk.fsf@posteo.net>
     [not found]               ` <87r0c3f1a4.fsf@web.de>
2024-07-09 10:06                 ` Thierry Volpiatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk37x4dg.fsf@posteo.net \
    --to=thievol@posteo.net \
    --cc=emacs-devel@gnu.org \
    --cc=me@eshelyaron.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.