From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.devel Subject: Re: MPS: marker-vector Date: Tue, 06 Aug 2024 08:02:32 +0200 Message-ID: <87bk26429z.fsf@gmail.com> References: <87ikxlqwu6.fsf@localhost> <87le2hp6ug.fsf@localhost> <87v81455iw.fsf@gmail.com> <87jzh8djdt.fsf@gmail.com> <87a5hqsq2l.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15978"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gerd =?utf-8?Q?M=C3=B6llmann?= , Stefan Monnier , Pip Cet , Ihor Radchenko , emacs-devel@gnu.org To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 06 08:03:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbDI2-00042w-1R for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Aug 2024 08:03:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbDHM-0000iX-RU; Tue, 06 Aug 2024 02:02:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbDHJ-0000i7-Sy for emacs-devel@gnu.org; Tue, 06 Aug 2024 02:02:37 -0400 Original-Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbDHI-0000b1-Bh; Tue, 06 Aug 2024 02:02:37 -0400 Original-Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a7ab76558a9so67910566b.1; Mon, 05 Aug 2024 23:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722924154; x=1723528954; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NUIk65FAplTLAAiqmT/Qy2pzYesnfF4c+w4aDUdjoR4=; b=E/aw9p+g3U3UOD3OYA8HluYeVPkbZIaZ6D1eeSeAukG3KI8C8hVcunghcJ22Gcpi9N sH8OLClcRg8wQgzSEPDhuG3pjKf9bp4ZCYkcY9x3lS5Qd8xzeIaPOy3BWkH8HKJZthHt i5+TPp936m2M7XLEAZ2UXnTfcyQsz1gTQ1ytwO11qyskPgwgu00V7XescOA2mD7kaT2G BVdIgSx/xTI7shOzgoLlB6g8mXrOWy255rMu11VoSyUg/ku3se8FjQZyN+GdelAdWRqz LHz035y+g95FwOl61NYNbaZ86S2ekDHCVXwz2Nm/0N18jOIY692NL3n4KaqfstpVrCIz nEfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722924154; x=1723528954; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NUIk65FAplTLAAiqmT/Qy2pzYesnfF4c+w4aDUdjoR4=; b=j+W10Mug/JvXD6kuokPPNm8ntTKcH/eo8a6tmSt3V+w9iBEHdbjd6btSraVlzdkkfF CZOCvCVZ5Byh9n6oGKChproRY5b56OHgcwl2Vw0O5cgrcQNW2ZDczvi69/i2AONcCXIB kAWeLDBnTQHklmoMQ5IDkkKfUUtdT2iMELWZ+qYHGIj0VOOahH48NVc2EbivHHJroczM f4+E9VjPSyX64CkUPtp1gHvkgthPuNLRnAb382jxxQzSI2BKDn/cfij1wAdPqNjr3d1a C6aHwnspPnaRsYK2+xqzLpjwS2Q8410li2HQP5dnO8qVtrOWXxkKz9yLDmKFOoSO09WQ X4zw== X-Forwarded-Encrypted: i=1; AJvYcCVbudXYxjmW1VZUqtt8jQc+89EMTyANyjWieik3BseaC37h1z6fO0Ib+7CFSjd3JCIWE+eLJUv4/Mye9Zkt+iazgR6z X-Gm-Message-State: AOJu0YxY/ilrKVqhais3g0tLoc4248SQeN044DyRBaIMsOY372BU1V7W 5dzqTyi+Nv5xvzVA4Gza5gUl7qW7W0YAgvCnPDFTznG9VPjpSAmrshAf8w== X-Google-Smtp-Source: AGHT+IGpqKWk5ha9mqo0hVeIQQoY+TQuM4I/dAbF3uNSxK6tRqN1B0mMGPJfP+KMNzDk6dALP+zjhQ== X-Received: by 2002:a17:907:1b1a:b0:a7a:bcbc:f7f4 with SMTP id a640c23a62f3a-a7dc5fbab30mr1252745466b.14.1722924153895; Mon, 05 Aug 2024 23:02:33 -0700 (PDT) Original-Received: from caladan (dialin-234199.rol.raiffeisen.net. [195.254.234.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9e8676fsm512967866b.164.2024.08.05.23.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Aug 2024 23:02:33 -0700 (PDT) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llman?= =?utf-8?Q?n=22's?= message of "Tue, 06 Aug 2024 05:59:17 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=eller.helmut@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322423 Archived-At: On Tue, Aug 06 2024, Gerd M=C3=B6llmann wrote: >> So the results of the growable array and the linked-list-of-markers >> would be closer. A downside of the growable array is that it needs a >> bit of extra code for the dumper. I didn't try to port the gap array >> code, because it seems like it would require many more changes and would >> make it even harder to merge with master. > > Hm, can't say much about the benchmark, I'm afraid. I've been > successfully ignoring this topic so far :-). I don't even know what the > impact of these numbers in a larger context is. > > That said, if you find it important, I trust that, so no objections from > me. Then I will ignore this too. > Technically speaking, from reading the diff, I think it's okay. The only > thing I'm wondering about is the compacting of the vector while > iterating over it. I can't put my finger on it, but Is that always safe? Modifying/adding/removing array entries while iterating over it is definitely problematic. But that that's probably also problematic for the vector-with-free-list.