From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73487: [PATCH] ; * src/cm.c (cmgoto): Add function documentation Date: Thu, 26 Sep 2024 22:54:36 +0100 Message-ID: <87bk0ankrn.fsf@jeremybryant.net> References: <87msjvo1vb.fsf@jeremybryant.net> <868qvec20t.fsf@gnu.org> Reply-To: Jeremy Bryant Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30349"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73487@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 27 00:03:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stwZe-0007fp-KY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Sep 2024 00:02:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stwZL-0003tv-2N; Thu, 26 Sep 2024 18:02:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stwZH-0003tf-B8 for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2024 18:02:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1stwZG-0005XC-M5 for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2024 18:02:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=uT4UUvJyFMUmERxDQHs822tEeBkKni6atz/lVqXqLec=; b=jmAA0+ifDyJpEiJXl0uLynBglbAeP+ZmyOAEQqpprb4xK4RZ+sYQyJzr4cK7Z6nbsQ7qDTPiSrEjvOCiVwbckTWATLCanZYSJBQ6y1XdmvsVzJcKc4Ox26EFFD2BSNj2koIvtRpeb2FXcGIQGkeGe8jdQC6Yxd2gHnSxurUwtPOmS/9Sx35Yj+gsf559uXARm5pBbQ9IlFL6+sycCz08FigmsbmMYI6+TzBgUQmH3k41KXN/u8n1V0lg03/mGS2hqZH4HJPu20b1cBu+RxQT5044ILr56kfEFTEbE+1ca2JRlkChoYc/UGxwJWpFGY9xzBD6AUplXSUBI4ZDyPnYWg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1stwZh-0001Ci-Ui for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2024 18:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Sep 2024 22:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73487 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73487-submit@debbugs.gnu.org id=B73487.17273881724597 (code B ref 73487); Thu, 26 Sep 2024 22:03:01 +0000 Original-Received: (at 73487) by debbugs.gnu.org; 26 Sep 2024 22:02:52 +0000 Original-Received: from localhost ([127.0.0.1]:55660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stwZY-0001C3-Fb for submit@debbugs.gnu.org; Thu, 26 Sep 2024 18:02:52 -0400 Original-Received: from out-173.mta1.migadu.com ([95.215.58.173]:57698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stwZW-0001Bd-5z for 73487@debbugs.gnu.org; Thu, 26 Sep 2024 18:02:51 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1727387679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uT4UUvJyFMUmERxDQHs822tEeBkKni6atz/lVqXqLec=; b=jbHVLw+MreeweGTVpT2gpGEsFR2evjaW1HskdsUmq5i6iQ//TOy3ZOQQYG+O0c0QPgX7Gd 4NGLTM4jUOlRslI1KjjmVUtRFhf1P/w4JOlXcO1ygUq4zu4jZKjCuXzvN2y58BqtxCPDni bKyab/9jsgonEw1tl0QP7HyK5wF1jS1eilUsL86yE/L8QjjLF4zhgf6KXFKCZ1mC7t0RIc Jt5Qf2267IFWWlqLD3pn2NYM9k+DJrTJOdEghYduG89b6tEfmArrzVydR82DoX4Ww0iZbn jFGu4ZNWOa02ZfJrs+hDXJsXSWiewZsAwuVvna5N2izgi807XA67bzqlhLWU7g== In-Reply-To: <868qvec20t.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 26 Sep 2024 10:22:42 +0300") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292483 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Date: Wed, 25 Sep 2024 22:32:56 +0100 >> From: Jeremy Bryant via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> This proposed patch adds a function documentation where there was none. >> >> Please install on master or provide feedback for further work. > > We usually prefer non-block comments, certainly when the comment is > short. Can you use that in this case? > > Thanks. Yes, sure. Revised patch attached with the comment in a single line, rather than a block. (I tried to match the style of the surrounding areas of the file but now realise this was from 1992) Please install on master or provide feedback for further work. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-src-cm.c-cmgoto-Add-function-documentation.patch >From afc9916447528682d72a6bd9429b2a6e91d4d28a Mon Sep 17 00:00:00 2001 From: Jeremy Bryant Date: Wed, 25 Sep 2024 22:28:04 +0100 Subject: [PATCH] ; * src/cm.c (cmgoto): Add function documentation --- src/cm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cm.c b/src/cm.c index ad419ce0af1..e1014af5298 100644 --- a/src/cm.c +++ b/src/cm.c @@ -317,6 +317,8 @@ #define USEHOME 1 #define USELL 2 #define USECR 3 +/* Move the cursor to (row, col), by computing the optimal way. */ + void cmgoto (struct tty_display_info *tty, int row, int col) { -- 2.45.2 --=-=-=--