From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Request to distribute Casual packages on NonGNU ELPA Date: Sat, 28 Sep 2024 14:02:57 +0000 Message-ID: <87bk07q3ji.fsf@posteo.net> References: <8B0830CA-6995-454C-BC5A-E4247E259CE9@gmail.com> <87a5fvsi0x.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Stefan Kangas , Stefan Monnier To: Charles Choi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 28 16:03:58 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1suY3B-0009rW-Uj for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Sep 2024 16:03:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1suY2N-0003yl-OK; Sat, 28 Sep 2024 10:03:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1suY2L-0003yU-LL for emacs-devel@gnu.org; Sat, 28 Sep 2024 10:03:05 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1suY2J-0006SZ-GA for emacs-devel@gnu.org; Sat, 28 Sep 2024 10:03:05 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 202EC240101 for ; Sat, 28 Sep 2024 16:02:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1727532179; bh=t6ht+6zFz6cai4jq01+eV7OxEPWj4Wv2liyDouWukBQ=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=M39ljTC0mJi1exxb2yjgsd0jlU6evkddfMUpLi0iqtXB94N8/qOKTcU1WUp3B9RmC nvCEzv0iBwl5EGs1taQBRplA7rZgHrUCF1B0KFtg26v4Cq51w0hQmHj/Z+CcZlXMgn RHaSe2sn/9c8EMnRvliGNODs/dTVLbRgwzUHK7yLCilV73AzUFJhRgCaEm1YRXMdR5 O4MOGWKQmXQm12qhow21kyjGUlYG7CgQdLTDakrPeOLyeLmKHIek5nXUxb30pbLwo9 MyheDuKeIW56xgQrG24roxOJ1RMzmncgic53x5Q5OwcIrxjbYGlTpxAXc+tnAIxtWw zNS41WyID3INw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XG8Df2Frnz6twr; Sat, 28 Sep 2024 16:02:58 +0200 (CEST) In-Reply-To: (Charles Choi's message of "Wed, 25 Sep 2024 13:05:22 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324169 Archived-At: --=-=-= Content-Type: text/plain Charles Choi writes: > https://github.com/kickingvegas/casual-isearch/ > https://github.com/kickingvegas/casual-symbol-overlay/ > https://github.com/kickingvegas/casual-avy/ > https://github.com/kickingvegas/casual-re-builder/ > https://github.com/kickingvegas/casual-dired/ > https://github.com/kickingvegas/casual-bookmarks/ > https://github.com/kickingvegas/casual-calc/ > https://github.com/kickingvegas/casual-ibuffer/ > https://github.com/kickingvegas/casual-info/ > https://github.com/kickingvegas/casual-agenda/ > https://github.com/kickingvegas/casual-editkit/ I have taken a look at all the repositories, with the exception of casual-calc, and the mostly seem the follow the same pattern. I don't have any special comments on the transient menus and their auxiliary functions. A little tip, the casual-...-about commands can be simplified by just generating a custom *Help* buffer: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/casual-isearch-settings.el b/lisp/casual-isearch-settings.el index f93aea2..78e2573 100644 --- a/lisp/casual-isearch-settings.el +++ b/lisp/casual-isearch-settings.el @@ -45,8 +45,11 @@ (interactive) (customize-group "isearch")) -(defun casual-isearch-about-isearch () - "Casual I-Search is a Transient menu for I-Search. +(defun casual-isearch-about () ;this might be better located in a manual + "About information for Casual I-Search." + (interactive) + (with-help-window "*About Casual Isearch*" + (princ "Casual I-Search is a Transient menu for I-Search. Learn more about using Casual I-Search at our discussion group on GitHub. Any questions or comments about it should be made there. @@ -65,13 +68,7 @@ San Francisco, California. Thank you for using Casual I-Search. -Always choose love." - (ignore)) - -(defun casual-isearch-about () - "About information for Casual I-Search." - (interactive) - (describe-function #'casual-isearch-about-isearch)) +Always choose love."))) (provide 'casual-isearch-settings) ;;; casual-isearch-settings.el ends here --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Other than that I can just strongly support the point that others have raised, that merging the functionality into a single package would be preferable. While at it, I would also recommend to keep everything related to what is currently a single package in one file. Drop the ...-version.el files, and instead refer the users to use describe-package (or analogous commands) if they want to know what version they have installed. As a upgrade procedure, I would recommend just copying everything into "casual-suite" and updating the remaining package with a top-level (warn "This package has been deprecated, please install `casual-suite'") A general comment is that I would recommend not treating this as a commercial product or service. It is just an Emacs package. > > https://github.com/kickingvegas/casual-suite/ [...] > All my best - > > Charles > > =E2=80=94 > Charles Y. Choi, Ph.D. > kickingvegas@gmail.com > > > > > --=20 Philip Kaludercic on siskin --=-=-=--