all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Pengji Zhang <me@pengjiz.com>
To: Juri Linkov <juri@linkov.net>, Jim Porter <jporterbugs@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Comint-like history search for Eshell?
Date: Mon, 04 Nov 2024 19:47:35 +0800	[thread overview]
Message-ID: <87bjyv2pbc.fsf@pengjiz.com> (raw)
In-Reply-To: <875xp3mqdb.fsf@mail.linkov.net>

Juri Linkov <juri@linkov.net> writes:

> The standard features that correspond to these two ways are
> incremental search with 'C-s' (implemented in the proposed patch)
> and occur with 'M-s o' (there is no occur-like interface for Eshell
> history AFAIK, it exists only for the minibuffer history, and
> in shell with 'comint-dynamic-list-input-ring').

In Eshell there is 'eshell-list-history', but it filters the history
using the bang expansion syntax, which is disabled by default now. In
Eshell, you may type 'C-c C-l' after

    $ !emacs

to get a buffer showing all history commands that start with 'emacs'. I
do not use bang expansion so I find it rarely useful.

> [...]
>
> So Eshell could have both as well: incremental search and completion.

I agree that we could implement both. For completion, if we are going to
let-bind 'completion-at-point-functions' as in Juri's and Sean's
commands (or use 'completion-in-region' as we do for the minibuffer),
then IMO there is nothing that hinders the implementation of an Isearch
interface.

Pengji



  reply	other threads:[~2024-11-04 11:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-03 13:23 Comint-like history search for Eshell? Pengji Zhang
2024-11-03 22:45 ` James Thomas
2024-11-03 23:09 ` Jim Porter
2024-11-03 23:28   ` Sean Whitton
2024-11-04  7:40   ` Juri Linkov
2024-11-04 11:47     ` Pengji Zhang [this message]
2024-11-04 19:12       ` Juri Linkov
2024-11-04  6:43 ` James Thomas
2024-11-08 21:02 ` James Thomas
2024-11-09 10:45   ` Pengji Zhang
2024-11-09 10:50   ` Pengji Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjyv2pbc.fsf@pengjiz.com \
    --to=me@pengjiz.com \
    --cc=emacs-devel@gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.